[Upstream] Goob UP - #168
Conversation
* ZED's infection nerf * okay NOW its working
* merge this without looking * you heard rouge gg
northstar yaml
* patchfix * patchfix2 * fix-oni --------- Co-authored-by: shimorio <shimoika@bk.ru>
* w * Fuck bro
…lds. (#6669) port Co-authored-by: gaiads <gaiads@users.noreply.github.com>
* Were it so easy * fix checkfail + proper weight * fix no agent ID
…olorlinks (#6682) * start * layering and colorlink real!!!!!! * xeno buff * fix meta * FUCK * sigh * i should probably remove this from my master branch already * emmmhm --------- Co-authored-by: Wink <vasilevruslan4152@gmail.com>
* Fix and rebalance mining injectors * Nerf exosuit drills * Nerf hierophant club * Allow ore boxes to dump ore by dragging it * fix
* fuck you * Dismember Greytide * it's growing * Revert "Dismember Greytide" This reverts commit f8f22a5c56b52df4f715ed6327d9d59185308107. * go away bro * Revert "go away bro" This reverts commit b930e1db25529044493fa2d69dc72e1a2da75357. * okay! * space goldfish * butterfly * Revert "butterfly" This reverts commit 520dca4aaa1fd2e2ecff8729859323a5d8fd88e6.
* hunger and thirst rebalance * hunger and thirst rebalance
* mpl 2 * Update .github/PULL_REQUEST_TEMPLATE.md --------- Co-authored-by: madeline-celeste <224184098+madeline-celeste@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs`:
- Line 121: Переместите запись LogType.CanisterTankInserted из обработчика
ItemSlotInsertAttemptEvent в уже существующий handler
EntInsertedIntoContainerMessage, чтобы логирование происходило только после
успешной вставки. Передайте в этот handler необходимый контекст вставки и не
логируйте отменённые попытки из ItemSlotInsertAttemptEvent.
In `@Resources/Locale/en-US/_DV/cosmiccult/abilities.ftl`:
- Around line 24-25: Добавьте русскую локализацию для ключа
cosmicability-hibernate-confirm в файле ru-RU/_DV/cosmiccult/abilities.ftl,
сохранив смысл предупреждения и инструкции подтверждения действия из английской
строки.
In `@Resources/Prototypes/_DV/Actions/cosmiccult.yml`:
- Line 239: В конфигурации ActionCosmicColossusSunder не отключайте общую
проверку доступности через checkCanAccess: false. Верните проверку
InRangeUnobstructed и реализуйте отдельное исключение только для окон, сохранив
блокировку выбора координат через стены, двери и прочие препятствия.
In `@Resources/Prototypes/Entities/Objects/Fun/sports.yml`:
- Around line 84-94: В определении TennisBall удалите или замените layer:
MobLayer, вернув объект в стандартный слой обычных предметов; при необходимости
сохраните слой, совместимый с MobMask, например MidImpassable, чтобы
столкновения с мобами действительно работали. Не изменяйте restitution,
friction, TileFrictionModifier или Damageable.
In `@Resources/Prototypes/Entities/Structures/Machines/Computers/computers.yml`:
- Line 1584: Добавьте проверку доступа через AccessReaderSystem в
RoboticsConsoleSystem.OnDisable() и OnDestroy() перед отправкой
NET_DISABLE_COMMAND или NET_DESTROY_COMMAND. Используйте настройки AccessReader
с доступом ResearchDirector из RoboticsConsole и блокируйте выполнение команды
при отсутствии доступа; сохраните текущую логику для авторизованных
пользователей.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ceeb6fe9-82be-4577-986f-b24b24e75af5
⛔ Files ignored due to path filters (5)
Resources/Textures/_Goobstation/Objects/Fun/tennis.rsi/equipped-MASK.pngis excluded by!**/*.pngResources/Textures/_Goobstation/Objects/Fun/tennis.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Goobstation/Objects/Fun/tennis.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Goobstation/Objects/Fun/tennis.rsi/tennis_ball.pngis excluded by!**/*.pngResources/Textures/_Goobstation/Objects/Fun/tennis.rsi/tennis_bundle_icon.pngis excluded by!**/*.png
📒 Files selected for processing (19)
Content.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csResources/Changelog/GoobChangelog.ymlResources/Locale/en-US/_DV/cosmiccult/abilities.ftlResources/Prototypes/Entities/Markers/Spawners/Random/toy.ymlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/_Goobstation/Entities/Objects/Fun/tennis.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Textures/_Goobstation/Objects/Fun/tennis.rsi/meta.json
💤 Files with no reviewable changes (3)
- Resources/Prototypes/Entities/Markers/Spawners/Random/toy.yml
- Resources/Textures/_Goobstation/Objects/Fun/tennis.rsi/meta.json
- Resources/Prototypes/_Goobstation/Entities/Objects/Fun/tennis.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: YAML Linter
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Test Packaging
🧰 Additional context used
📓 Path-based instructions (18)
Resources/**/*.{yml,ftl,json}
📄 CodeRabbit inference engine (.cursor/rules/ss14-resources.mdc)
Resources/**/*.{yml,ftl,json}: Follow SS14 naming conventions when editing prototype, localization, and resource files
Follow SS14 upstream maintenance practices when editing resource files
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Locale/en-US/_DV/cosmiccult/abilities.ftlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
Resources/**/*.yml
📄 CodeRabbit inference engine (.cursor/rules/ss14-resources.mdc)
Resources/**/*.yml: Follow SS14 ECS prototype patterns and conventions
Follow SS14 graphics generic visualizer appearance conventions and patterns
Resources/**/*.yml: Loadss14-naming-conventionsdocumentation for Resources work
Loadss14-ecs-prototypesdocumentation for Resources work
Loadss14-upstream-maintenancedocumentation for Resources work
Loadss14-prototypes-localedocumentation for Resources work
Loadss14-localization-stringsdocumentation for Resources work
Loadss14-sprite-overlays-shadersdocumentation when working with RSI metadata, textures, sprite layers, overlays, or shader resources
Validate YAML after editsRun
dotnet run --project Content.YAMLLinter/Content.YAMLLinter.csproj -c DebugOptto validate YAML and resource edits.
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
Resources/**/*.{yml,ftl}
📄 CodeRabbit inference engine (.cursor/rules/ss14-resources.mdc)
Follow SS14 prototype locale integration rules and practices
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Locale/en-US/_DV/cosmiccult/abilities.ftlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
**/*.{cs,xaml,yml,yaml}
📄 CodeRabbit inference engine (AGENTS.md)
If the task adds tests or you need to choose the right test layer, load skill
ss14-tests-authoring.
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlContent.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.csResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
Resources/Prototypes/**/*.yml
📄 CodeRabbit inference engine (AGENTS.md)
Resources/Prototypes/**/*.yml: Put prototypes under the most specific existing subtree inResources/Prototypes/. If you introduce a new prototype parent tree, put parent prototypes inbase.ymland variants in sibling files.
Keep entity prototype field order astype,abstract,parent,id,categories,name,suffix,description,components. Do not insert blank lines between- type:entries inside acomponents:list. Separate prototype blocks with one blank line.
Prefersuffixfor spawn-menu distinctions instead of changing prototypename.
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.yml
⚙️ CodeRabbit configuration file
Resources/Prototypes/**/*.yml: Review SS14 prototypes carefully:
- Use the narrowest existing subtree and avoid duplicating nearby prototype files or parent trees.
- Keep entity field order as: type, abstract, parent, id, categories, name, suffix, description, components.
- Prefer base.yml for parent trees and sibling files for variants.
- Do not add blank lines inside components lists.
- Call out broken inheritance, risky prototype ID changes, missing paired locale updates, and Appearance / GenericVisualizer mismatches.
Files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.yml
**/*.cs
📄 CodeRabbit inference engine (GEMINI.md)
**/*.cs: Keep components data-only and behavior in systems
UseOn... -> Try... -> Can... -> Do...pattern for gameplay actions
PreferEntity<T?>,ProtoId<T>,EntProtoId, and localized strings for type usage
**/*.cs: When writing or editing C# gameplay code, load skills:ss14-ecs-components,ss14-ecs-entities,ss14-ecs-prototypes,ss14-ecs-systems,ss14-events, andss14-prediction.
If the C# change is large or the task needs reviewable notes, load skillss14-documentation-writing.
If the code touches hot paths,Update(), or frequently raised events, load skillss14-standard-optimizations.
If the task adds or changes player-facing text, load skillsss14-localization-stringsandss14-localization-codewhen the change also touchesLoc.GetString(...),LocId, popup text, or localized component fields.
If the task touches network events,NetEntity, replicated state routing, or shared/server/client message flow, load skillss14-netcode.
If the task touchesAppearance,GenericVisualizer, visual state enums, or sprite-layer toggles, load skillss14-graphics-generic-visualizer-appearance.
If the task touches sprites, RSI metadata, overlays, shaders, or custom client visual effects, load skillss14-sprite-overlays-shaders.
If the task is about learning or explaining SS14 architecture, first features, or where code belongs, load skillsss14-prototype-basics,ss14-ecs-basics, andss14-client-server-shared.
If the task is about bug hunting, VV, logs, breakpoints, or runtime inspection, load skillsss14-debugging-workflowandss14-common-api-patterns.
If the task touches common gameplay helpers such as entity-system methods, spawning, prototypes, audio, popups, or random, load skillsss14-common-api-patternsandss14-audiowhen the work changes audio routing, sound assets, sound collections, or predicted sound feedback.
If the task ports code or assets from another repository, or needs license or attribution guidance,...
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
Content.Shared/**
📄 CodeRabbit inference engine (Content.Shared/AGENTS.md)
Content.Shared/**: Load ss14-naming-conventions agent notes for Content.Shared work
Load ss14-ecs-prototypes, ss14-ecs-components, ss14-ecs-entities, and ss14-ecs-systems agent notes for Content.Shared work
Load ss14-upstream-maintenance agent notes for Content.Shared work
Load ss14-events agent notes for Content.Shared work
Load ss14-prediction and ss14-netcode agent notes for Content.Shared work
Load ss14-localization-code agent notes when shared code emits player text or stores LocId
Load ss14-graphics-generic-visualizer-appearance agent notes when shared gameplay state drives Appearance or GenericVisualizer
Load ss14-audio agent notes when shared components or events carry sound specifiers or predicted audio intent
Load ss14-atmos agent notes when shared components, UI messages, or enums belong to atmos features
Load ss14-transform-physics agent notes for shared coordinates, movement, collision, anchoring, or physics contracts
Load ss14-pvs agent notes for PVS-sensitive shared/network contracts
Load ss14-npc-ai agent notes for shared NPC, HTN, steering, pathfinding, or debug contracts
Shared code must own replicated state, shared events, and prediction-aware logic without adding direct client-only or server-only dependencies
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs
+(Content.Shared|Content.Server|Content.Client|Content.Goobstation.Shared|Content.Goobstation.Server|Content.Goobstation.Client|Content.Goobstation.Common|Content.Goobstation.Maths|Content.Goobstation.UIKit|Content.Server.Database|Content.Shared.Database|Content.Tests|Content.IntegrationTests)/**/*.cs
📄 CodeRabbit inference engine (.cursor/rules/ss14-csharp.mdc)
+(Content.Shared|Content.Server|Content.Client|Content.Goobstation.Shared|Content.Goobstation.Server|Content.Goobstation.Client|Content.Goobstation.Common|Content.Goobstation.Maths|Content.Goobstation.UIKit|Content.Server.Database|Content.Shared.Database|Content.Tests|Content.IntegrationTests)/**/*.cs: Apply C# ECS style rules from ss14-interaction-flow.md
Apply ss14-csharp-style.md rules for C# code formatting and conventions
Follow ss14-naming-conventions for variable, method, and type naming in C# gameplay code
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
{Content.Shared,Content.Goobstation.Shared,Content.Goobstation.Common,Content.Goobstation.Maths,Content.Shared.Database}/**/*.cs
📄 CodeRabbit inference engine (.cursor/rules/ss14-shared.mdc)
{Content.Shared,Content.Goobstation.Shared,Content.Goobstation.Common,Content.Goobstation.Maths,Content.Shared.Database}/**/*.cs: Apply SS14 C# style guidelines from @.agents/rules/ss14-csharp-style.md
Follow SS14 ECS component patterns as defined in @.agents/skills/ss14-ecs-components/SKILL.md
Follow SS14 ECS entity patterns as defined in @.agents/skills/ss14-ecs-entities/SKILL.md
Follow SS14 ECS system patterns as defined in @.agents/skills/ss14-ecs-systems/SKILL.md
Follow SS14 event patterns as defined in @.agents/skills/ss14-events/SKILL.md
Follow SS14 prediction-aware gameplay code patterns as defined in @.agents/skills/ss14-prediction/SKILL.md
Follow SS14 netcode patterns as defined in @.agents/skills/ss14-netcode/SKILL.md
Follow SS14 localization identifier patterns as defined in @.agents/skills/ss14-localization-code/SKILL.md
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs
{**/_Orion,**/_Goobstation,**/_EinsteinEngines,**/_Shitmed,**/_DV,**/_NF,**/_Mono,**/_RMC14,**/_White}/**/*.cs
📄 CodeRabbit inference engine (AGENTS.md)
For Orion-only behavior, prefer existing
_Orionfolders when they exist. This repository also contains inherited/vendor-specific trees such as_Goobstation,_EinsteinEngines,_Shitmed,_DV,_NF,_Mono,_RMC14,_White, and others; extend the tree that already owns the feature instead of assuming all fork code belongs under_Orion.
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
{Content.Shared,Content.Goobstation.Shared}/**/*.cs
📄 CodeRabbit inference engine (AGENTS.md)
{Content.Shared,Content.Goobstation.Shared}/**/*.cs: Put main shared data, shared events, networked state, and predicted logic inContent.Shared/; useContent.Goobstation.Shared/only for code that belongs to that existing module path.
Do not make shared projects depend on client-only or server-only projects.
Predicted systems and their relevant components belong inContent.Shared/. Shared predicted components should useNetworkedComponent,AutoGenerateComponentState, andAutoNetworkedFieldwhere appropriate.
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs
Content.Shared/**/*.cs
⚙️ CodeRabbit configuration file
Content.Shared/**/*.cs: Review Content.Shared as shared gameplay and prediction code:
- Shared owns replicated state, shared events, prediction, and data both client and server must understand.
- Flag client-only or server-only dependencies in Shared.
- For local-player actions, verify prediction support instead of accepting delayed server-only UX.
- When state is networked, check NetworkedComponent, AutoGenerateComponentState, AutoNetworkedField, and Dirty/DirtyField usage.
- Prefer entity-system APIs and Entity<T?> / Resolve patterns over ad-hoc tuples or old-style access.
- Flag EntityUid.Invalid used as a "missing" sentinel.
Files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs
**/*System.cs
📄 CodeRabbit inference engine (AGENTS.md)
Public entity-system APIs that operate on entities should usually take
Entity<T?>orEntityUidfirst and callResolve(...)early.
Files:
Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
Resources/**/*.ftl
📄 CodeRabbit inference engine (.cursor/rules/ss14-resources.mdc)
Follow SS14 localization string standards and formatting rules
Files:
Resources/Locale/en-US/_DV/cosmiccult/abilities.ftl
**/*.ftl
📄 CodeRabbit inference engine (AGENTS.md)
Use specific
kebab-caselocalization IDs.
Files:
Resources/Locale/en-US/_DV/cosmiccult/abilities.ftl
Resources/Locale/**/*.ftl
📄 CodeRabbit inference engine (AGENTS.md)
Resources/Locale/**/*.ftl: Add or update FTL entries underResources/Locale/, starting withen-US; add/update matchingru-RUentries when the same feature already maintains Russian locale or the change is Orion-facing and you can do so without guessing translations.
Use specifickebab-caselocalization IDs.
Files:
Resources/Locale/en-US/_DV/cosmiccult/abilities.ftl
⚙️ CodeRabbit configuration file
Resources/Locale/**/*.ftl: Treat localization as mandatory:
- Every player-facing string should be localized.
- Prefer specific kebab-case keys.
- Flag raw strings in code or gameplay/resource changes that are missing locale updates.
- Check consistency when prototype names, descriptions, markings, or UI text changed.
Files:
Resources/Locale/en-US/_DV/cosmiccult/abilities.ftl
{Content.Server,Content.Goobstation.Server}/**/*.cs
📄 CodeRabbit inference engine (AGENTS.md)
Put main server-only authority and non-predicted server simulation in
Content.Server/; useContent.Goobstation.Server/for features already rooted in that module.
Files:
Content.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
Content.Server/**/*.cs
⚙️ CodeRabbit configuration file
Content.Server/**/*.cs: Review Content.Server for authority and fork-maintenance discipline:
- Server owns authority, persistence, round logic, and non-predicted side effects.
- If a player action should feel immediate, call out missing shared prediction rather than accepting a server-only path.
- Keep upstream diffs narrow and prefer fork-scoped extensions over broad edits to upstream behavior.
- When player-visible behavior changes, check whether matching prototype and locale updates are missing.
Files:
Content.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
🧠 Learnings (12)
📚 Learning: 2026-06-29T05:34:31.137Z
Learnt from: Alazell
Repo: ArcaneSS14/arcane-station PR: 99
File: Resources/Prototypes/Entities/Clothing/Belt/belts.yml:973-974
Timestamp: 2026-06-29T05:34:31.137Z
Learning: В SS14 YAML-прототипах для компонента `Storage` поле `grid` задаёт **включительные** координаты прямоугольника. При подсчёте вместимости учитывайте оффсет-инклюзивность: прямоугольник `x1,y1,x2,y2` означает размеры `width = (x2 - x1 + 1)` и `height = (y2 - y1 + 1)`, а число ячеек `width * height`. Например, `0,0,0,0` = 1 ячейка, а `0,0,6,2` = (6-0+1)*(2-0+1)=7*3=21. При ревью файлов наподобие `Resources/Prototypes/Entities/Clothing/Belt/belts.yml` не интерпретируйте `x2/y2` как эксклюзивные (чтобы не ошибиться на 1 в ширине/высоте).
Applied to files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.yml
📚 Learning: 2026-07-29T08:12:37.068Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane PR: 153
File: Resources/Prototypes/_Orion/Entities/Objects/Tools/energy_dome.yml:137-137
Timestamp: 2026-07-29T08:12:37.068Z
Learning: In ArcaneSS14 prototype YAMLs, the YAML field that disables synchronization for `Content.Shared.Power.Components.BatteryComponent` is spelled exactly `netsync` (all lowercase), not `netSync`. For prototypes derived from `PowerNetworkBattery` (including `BaseAPC`, `CoreSubstation`, `BaseSMES`, `TeslaCoil`), set `netsync: false`; otherwise `Content.Server.Power.EntitySystems.BatterySystem.OnStartup` can throw `DebugAssertException` for a predicted battery connected to a power net. For `Resources/Prototypes/_Orion/Entities/Objects/Tools/energy_dome.yml`, ensure `EnergyDomeWiredTest` uses `netsync: false`.
Applied to files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.yml
📚 Learning: 2026-07-07T17:55:50.395Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane-old PR: 101
File: Content.Client/Chemistry/UI/ChemMasterWindow.xaml.cs:192-194
Timestamp: 2026-07-07T17:55:50.395Z
Learning: When reviewing ArcaneSS14/arcane-old changes related to `MobState` thresholds/visuals/actions, treat the `Critical` enum value as requiring explicit mappings (it no longer implicitly behaves as an alias of `SoftCritical`). If any YAML prototype `thresholds:` (for `MobThresholdsComponent.Thresholds`) uses the bare `Critical` key (e.g., `MobThresholdsComponent.Thresholds: { Critical: ... }` for entities like `MobMouseCancer`), ensure the prototype (or referenced config) provides corresponding explicit `StateAlertDict` entries and any required `MobStateActions.actions` and `DamageStateVisuals.states` mappings for `Critical`. Otherwise, review should expect failures because the default `StateAlertDict` in `MobThresholdsComponent.cs` typically maps only `Alive`, `SoftCritical`, `HardCritical`, and `Dead`—not `Critical`.
Applied to files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
📚 Learning: 2026-07-28T15:44:38.498Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane PR: 152
File: Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Cartridges/pistol.yml:69-72
Timestamp: 2026-07-28T15:44:38.498Z
Learning: В ArcaneSS14/arcane не выполняйте форматирующие перестановки полей (в т.ч. изменение порядка полей) в upstream-файлах: делайте это только если правка добавляет Arcane-специфичную сущность или напрямую требуется для функциональности. Иначе сохраняйте upstream-порядок полей, даже если он противоречит локальным рекомендациям, чтобы не создавать лишние diff и конфликты при upstream-синхронизации. Исключение: допустимо переупорядочивание/форматирование в `Resources/Prototypes/_Arcane` (и только там).
Applied to files:
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.ymlResources/Prototypes/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.ymlResources/Prototypes/Entities/Structures/Machines/Computers/computers.ymlResources/Prototypes/_DV/CosmicCult/damage_modifier_sets.ymlResources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.ymlResources/Prototypes/_DV/CosmicCult/Mobs/colossus.ymlResources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.ymlResources/Prototypes/_DV/Actions/cosmiccult.ymlResources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.ymlResources/Prototypes/Entities/Objects/Fun/sports.ymlResources/Changelog/GoobChangelog.yml
📚 Learning: 2026-06-04T21:17:36.815Z
Learnt from: MataVsn
Repo: ArcaneSS14/arcane-station PR: 31
File: Content.Client/Fluids/PuddleSystem.cs:41-41
Timestamp: 2026-06-04T21:17:36.815Z
Learning: In this repo (ArcaneSS14/arcane-station), reviewers should use the Arcane inline fork-edit marker naming for single-line edits outside `_Arcane` paths: prefer `// Arcane` or `// Arcane-edit` and do not use `// Orion` for this purpose. Repo-specific AGENTS guidance that mentions `// Orion` does not apply to these single-line changes; only `_Arcane` paths follow the applicable different convention.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
📚 Learning: 2026-06-28T19:37:26.732Z
Learnt from: MataVsn
Repo: ArcaneSS14/arcane-station PR: 96
File: Content.Client/IoC/ClientContentIoC.cs:151-151
Timestamp: 2026-06-28T19:37:26.732Z
Learning: For ArcaneSS14/arcane-station C# files whose path is outside any `_Arcane` directories, avoid adding an inline fork marker (e.g., `// Arcane` or `// Arcane-edit`) to `using` directives when the imported namespace already clearly indicates the `_Arcane` fork. For example, if the `using` namespace itself contains `_Arcane` (such as `using Content.Client._Arcane.ERP.Preferences;`), the `// Arcane`/`// Arcane-edit` marker is unnecessary.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
📚 Learning: 2026-07-04T03:37:47.373Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane-station PR: 101
File: Content.Goobstation.Server/Chemistry/EntitySystems/EnergyReagentDispenserSystem.cs:59-59
Timestamp: 2026-07-04T03:37:47.373Z
Learning: In ArcaneSS14/arcane-station, C# source files must never have fork-edit markers (e.g., comments like `// Arcane`, `// Arcane-edit`, `// Orion`) on `using` directives. During code review, do not flag existing markers on any `using` line and do not suggest adding/removing them based on `_Arcane` folder placement or whether the imported namespace contains `_Arcane`—this rule applies universally to all `using` statements.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
📚 Learning: 2026-07-28T16:30:37.419Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane PR: 133
File: Content.Server/Speech/EntitySystems/StutteringSystem.cs:28-29
Timestamp: 2026-07-28T16:30:37.419Z
Learning: При внесении одиночных fork-правок в репозитории ArcaneSS14/arcane вне путей `_Arcane` добавляйте в конец каждой изменённой строки комментарий-маркер `// Arcane-Edit`. Это нужно для упрощения последующего поиска/обновления подобных правок при код-ревью и синхронизациях.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
📚 Learning: 2026-06-28T12:09:12.409Z
Learnt from: MataVsn
Repo: ArcaneSS14/arcane-station PR: 96
File: Content.Shared/Humanoid/HumanoidVisualLayers.cs:65-67
Timestamp: 2026-06-28T12:09:12.409Z
Learning: In ArcaneSS14/arcane-station, for any C# enum annotated with `[NetSerializable]` in shared code, treat the enum member order/implicit underlying numeric values as part of the network wire-protocol. During code review, disallow inserting new enum members in the middle (or otherwise changing existing members’ numeric values), since it breaks network compatibility. Instead, add new members only at the end or explicitly pin stable values by assigning numeric literals to members.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs
📚 Learning: 2026-07-01T17:19:52.100Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane-station PR: 101
File: Content.Shared/Mobs/MobState.cs:0-0
Timestamp: 2026-07-01T17:19:52.100Z
Learning: When reviewing ArcaneSS14/arcane-station C# code, ensure all usages of the `MobState` enum (`MobState.Dead`, `MobState.SoftCritical`, `MobState.HardCritical`, `MobState.Critical`) reference the enum members symbolically rather than via hardcoded numeric literals or casts from numeric values (e.g., avoid patterns like `(MobState)4` or `MobState` comparisons to `byte`/`int` literals). Treat direct numeric usage as a code-level dependency that should be flagged. Also avoid persisting `MobState` numeric values in `Content.Server.Database` or `Content.Replay`; if persistence/replay of the raw byte value is introduced, renumbering the `[NetSerializable] MobState : byte` enum becomes a data-compatibility risk. Renumbering the enum is compile-safe as long as there are no numeric literal dependencies, but the remaining risk is network wire-protocol mismatch if mixed old/new client-server builds are running during a rolling update—coordinate deployment to maintain net compatibility.
Applied to files:
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.csContent.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
📚 Learning: 2026-07-05T18:40:45.199Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane-station PR: 101
File: Resources/Prototypes/_Orion/Entities/Objects/Specific/Medical/medkits.yml:0-0
Timestamp: 2026-07-05T18:40:45.199Z
Learning: For ArcaneSS14/arcane-station custom `_Arcane`/`_Orion` entity prototypes under `Resources/Prototypes/_Arcane/` or `Resources/Prototypes/_Orion/`, embed `name` and `description` directly in the prototype `.yml` as the `en-US` fallback text (do not add a separate `en-US` locale override). Then localize only `ru-RU` by adding `ent-<EntityId>` and `ent-<EntityId>.desc` keys in `Resources/Locale/ru-RU/ss14-ru/prototypes/_arcane/...` or `.../_orion/...`, mirroring the entity `.yml` path. By contrast, vanilla-derived entities (e.g., a base `Medkit`) should omit `name`/`description` from the `.yml` entirely and instead provide both `en-US` and `ru-RU` localized `prototypes/...` entries in `Resources/Locale/{en-US,ru-RU}/ss14-ru/prototypes/...`.
Applied to files:
Resources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.yml
📚 Learning: 2026-07-03T18:41:44.286Z
Learnt from: UmbiMax
Repo: ArcaneSS14/arcane-station PR: 101
File: Content.Shared/_Orion/EntityEffects/Effects/Special/ChemConvermol.cs:0-0
Timestamp: 2026-07-03T18:41:44.286Z
Learning: In ArcaneSS14/arcane-station, the hardcoded 1.2f base used by RefreshPartsEvent.GetLinearMultiplier(tier, step, min, max) (Math.Clamp(1.2f - tier * step, min, max)) is an intentional repo-wide balance convention: callers typically pass max: 1.2f, so a tier-1 part yields a 10% penalty (e.g., GetLinearMultiplier(tier: 1, step: 0.1f, min: 0.5f, max: 1.2f) => 1.1), while tier-2 is the neutral baseline. Do not flag the hardcoded 1.2f as a bug when reviewing shared multiplier/linear scaling usage. If a specific system needs a tier-1 baseline that produces 0% penalty instead, implement a locally-scoped formula in that system (e.g., adjust the constant to match the desired neutral baseline) rather than changing the shared helper, since modifying it would affect all callers’ balance.
Applied to files:
Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.csContent.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs
🔇 Additional comments (11)
Resources/Changelog/GoobChangelog.yml (1)
24112-24153: LGTM!Resources/Prototypes/Loadouts/Miscellaneous/trinkets.yml (1)
18-18: LGTM!Also applies to: 25-25, 33-33, 41-41, 48-48, 347-347, 361-361, 375-375, 387-387, 400-400
Resources/Prototypes/_Orion/Loadouts/Miscellaneous/wrists.yml (1)
25-25: LGTM!Also applies to: 31-31
Content.Shared/_DV/CosmicCult/Components/CosmicColossusComponent.cs (1)
49-49: LGTM!Content.Server/_EinsteinEngines/TelescopicBaton/KnockdownOnHitSystem.cs (1)
11-20: LGTM!Also applies to: 52-56
Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml (1)
11-11: LGTM!Resources/Prototypes/_DV/Catalog/VendingMachines/Inventories/salvage_points.yml (1)
73-74: LGTM!Also applies to: 99-100
Resources/Prototypes/_DV/CosmicCult/Mobs/colossus.yml (1)
256-257: LGTM!Also applies to: 398-398
Resources/Prototypes/_DV/CosmicCult/damage_modifier_sets.yml (1)
8-8: LGTM!Resources/Prototypes/_Goobstation/Catalog/Cargo/cargo_fun.yml (1)
84-85: 🎯 Functional CorrectnessИзменение корректно.
Resources/Prototypes/_DV/Loadouts/Miscellaneous/trinkets.yml (1)
9-9: 🎯 Functional CorrectnessОставьте закомментированным.
groupBy: "ring"находится внутри закомментированных блоков loadout, поэтому текущая правка не меняет загружаемые конфигурации.> Likely an incorrect or invalid review comment.
| { | ||
| args.Cancelled = true; | ||
| } | ||
| AdminLogger.Add(LogType.CanisterTankInserted, LogImpact.Medium, $"Player {ToPrettyString(args.User):player} inserted tank {ToPrettyString(args.Item):tank} into {ToPrettyString(uid):canister}"); // Goobstation |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n -C 12 \
'ItemSlotInsertAttemptEvent|EntInsertedIntoContainerMessage|CanisterTankInserted|ISharedAdminLogManager|AdminLogger\.Add' \
Content.Shared Content.Server Content.ClientRepository: ArcaneSS14/arcane
Length of output: 50374
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Inspect the shared canister system and nearby handler logic.
sed -n '1,180p' 'Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs'
# Locate admin log type and exact references without large context.
rg -n -C 3 'CanisterTankInserted|OnCanisterInsertAttempt|SubscribeLocalEvent<.*ItemSlotInsertAttemptEvent|RaiseLocalEvent<.*ItemSlotInsertAttemptEvent|ItemSlotInsertAttemptEvent' \
Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs \
Content.Server/Atmos Content.Shared/Atmos \
--glob '*.cs' | head -n 120Repository: ArcaneSS14/arcane
Length of output: 11599
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Find where ItemSlotInsertAttemptEvent is raised/fulfilled and whether cancellation is checked before mutation.
rg -n -C 16 'RaiseLocalEvent<.*ItemSlotInsertAttemptEvent|RaiseLocalEvent\(|RaisePipelinedEvent<.*ItemSlotInsertAttemptEvent|ItemSlotInsertAttemptEvent|class ItemSlotInsertAttemptEvent' Content Shared Interfaces --glob '*.cs' | head -n 220
# Also inspect the shared item slots handler candidates.
rg -n -C 8 'ItemSlotsSystem|ItemSlotInsertAttemptEvent|On.*Attempt|RaisePipelinedEvent' Content.Shared/Containers/Content.Shared/Atmos --glob '*.cs' | head -n 220 || trueRepository: ArcaneSS14/arcane
Length of output: 313
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Find where ItemSlotInsertAttemptEvent is raised/fulfilled and whether cancellation is checked before mutation.
rg -n -C 16 'RaiseLocalEvent<.*ItemSlotInsertAttemptEvent|RaiseLocalEvent\(|RaisePipelinedEvent<.*ItemSlotInsertAttemptEvent|ItemSlotInsertAttemptEvent|class ItemSlotInsertAttemptEvent' . --glob '*.cs' | head -n 260
# Also inspect shared slot handlers that are likely candidates.
rg -n -C 8 'ItemSlotsSystem|ItemSlotInsertAttemptEvent|On.*Attempt|RaisePipelinedEvent' Content.Shared/Containers Content.Shared/Atmos contentshared ContentShared --glob '*.cs' || trueRepository: ArcaneSS14/arcane
Length of output: 50373
Записывайте CanisterTankInserted только после успешной вставки предмета.
ItemSlotInsertAttemptEvent поднимается перед проверкой ev.Cancelled; текущий код ставит args.Cancelled = true для открытого клапана или неверного предмета, но после этого всё равно создаёт запись админ-лога. Используйте уже существующий handler EntInsertedIntoContainerMessage для авторитетной точки аудита и передавайте туда контекст вставки вместо пользовательских попыток вставки.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Content.Shared/Atmos/Piping/Unary/Systems/SharedGasCanisterSystem.cs` at line
121, Переместите запись LogType.CanisterTankInserted из обработчика
ItemSlotInsertAttemptEvent в уже существующий handler
EntInsertedIntoContainerMessage, чтобы логирование происходило только после
успешной вставки. Передайте в этот handler необходимый контекст вставки и не
логируйте отменённые попытки из ItemSlotInsertAttemptEvent.
Source: Path instructions
|
@coderabbitai Куда провал Амбер? Провал тестов |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
echo "== PR checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
head_sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== Failed check runs =="
gh api "repos/$repo/commits/$head_sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Amber references in failed-job logs =="
gh api "repos/$repo/commits/$head_sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| while IFS= read -r url; do
run_id="$(printf '%s\n' "$url" | sed -nE 's#.*actions/runs/([0-9]+).*#\1#p')"
if [ -n "$run_id" ]; then
gh run view "$run_id" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 3 'amber|test.*fail|fail.*test|error|exception' \
|| true
fi
doneLength of output: 4108 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
for job in 91657549737 91656425008; do
echo "== Failed log for job $job =="
gh run view --repo "$repo" --job "$job" --log-failed 2>&1 | tee "/tmp/job-$job.log" >/dev/null || true
echo "-- terminal error context --"
rg -in -C 8 \
'##\[error\]|error [A-Z]+[0-9]+:|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|Build FAILED|Process completed with exit code|failed' \
"/tmp/job-$job.log" \
| tail -n 220 || true
doneLength of output: 1090 🏁 Script executed: #!/bin/bash
set -u
repo="ArcaneSS14/arcane"
for job in 91657549737 91656425008; do
echo "== Failed log for job $job =="
gh run view --repo "$repo" --job "$job" --log-failed 2>&1 \
| rg -in -C 10 \
'##\[error\]|error [A-Z]+[0-9]+:|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|Build FAILED|Process completed with exit code|failed' \
| tail -n 240 \
|| true
doneLength of output: 18763 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== PR changes related to Amber and map pools =="
git diff --name-status 'origin/master...HEAD' \
| rg -i '(^|/)(default\.yml|amber|maps?)(/|$)' \
|| true
echo "== Current map-pool reference =="
pool="$(fd -a '^default\.yml$' Resources 2>/dev/null | rg '/Prototypes/Maps/Pools/default\.yml$' | head -n 1 || true)"
if [ -n "$pool" ]; then
nl -ba "$pool" | sed -n '1,40p'
fi
echo "== Current Amber prototype definitions and references =="
rg -n -i -C 4 '(^|[[:space:]-])id:[[:space:]]*Amber([[:space:]#]|$)|mapName:[[:space:]]*Amber([[:space:]#]|$)|Amber' \
Resources/Prototypes/Maps Resources/Maps 2>/dev/null \
|| true
echo "== Base-to-PR changes containing Amber =="
git diff --find-renames --unified=5 'origin/master...HEAD' -- Resources \
| rg -n -i -C 5 'Amber|Prototypes/Maps/Pools/default\.yml' \
|| trueLength of output: 1291 🏁 Script executed: #!/bin/bash
set -u
echo "== Map pool files named default.yml =="
fd -a '^default\.yml$' Resources 2>/dev/null \
| while IFS= read -r file; do
case "$file" in
*/Prototypes/Maps/Pools/default.yml)
echo "-- $file --"
awk 'NR <= 30 { printf "%4d %s\n", NR, $0 }' "$file"
;;
esac
done
echo "== Amber references under Resources =="
rg -n -i -C 3 '\bAmber\b' Resources 2>/dev/null || true
echo "== PR diff paths containing map pool or Amber =="
git diff --name-status 'origin/master...HEAD' \
| rg -i 'Maps/Pools|Amber' \
|| true
echo "== Diff changes to map-pool references =="
git diff --find-renames --unified=4 'origin/master...HEAD' -- Resources \
| rg -n -i -C 4 'Amber|Maps/Pools/default\.yml' \
|| trueLength of output: 32451
You are interacting with an AI system. |
|
@coderabbitai Прототип карты имеется в _Arcane.
|
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Amber gameMap definitions =="
rg -n -i -C 8 '^\s*id:\s*Amber\s*$|^\s*mapName:\s*['\''"]?Amber' Resources/Prototypes 2>/dev/null || true
echo
echo "== YAML files under _Arcane that mention Amber =="
fd -a -e yml -e yaml . Resources/Prototypes/_Arcane 2>/dev/null \
| while IFS= read -r file; do
if rg -q -i '\bAmber\b' "$file"; then
echo "-- $file --"
rg -n -i -C 5 '\bAmber\b|availableJobs:' "$file"
fi
done
echo
echo "== StationJobs role lists from map prototypes =="
fd -a -e yml -e yaml . Resources/Prototypes/Maps Resources/Prototypes/_Arcane 2>/dev/null \
| while IFS= read -r file; do
if rg -q '^\s*-\s*type:\s*StationJobs\s*$' "$file"; then
echo "-- $file --"
awk '
/^[[:space:]]*-[[:space:]]*type:[[:space:]]*StationJobs[[:space:]]*$/ { on=1 }
on { print }
on && /^[[:space:]]*-[[:space:]]*type:/ && $0 !~ /StationJobs/ { exit }
' "$file"
fi
done
echo
echo "== Registered job prototype IDs =="
fd -a -e yml -e yaml . Resources/Prototypes/Roles Resources/Prototypes/_Arcane 2>/dev/null \
| xargs -r rg -n -P '^\s*id:\s*[A-Za-z][A-Za-z0-9]*\s*$' \
| head -n 1200Length of output: 159911 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Candidate role definitions =="
for role in Adjutant CommandMaid Roboticist IAA Brigmedic Virologist; do
echo "-- $role --"
rg -n -U -P "(?s)- type: job\\R\\s*id:\\s*${role}\\b" Resources/Prototypes 2>/dev/null || true
done
echo
echo "== Candidate role use in map StationJobs =="
for role in Adjutant CommandMaid Roboticist IAA Brigmedic Virologist; do
printf '%-14s ' "$role"
rg -l -P "^[[:space:]]*${role}:\\s*\\[" Resources/Prototypes/Maps Resources/Prototypes/_Arcane/Maps 2>/dev/null \
| wc -l
rg -n -P "^[[:space:]]*${role}:\\s*\\[" Resources/Prototypes/Maps Resources/Prototypes/_Arcane/Maps 2>/dev/null || true
done
echo
echo "== All role IDs used by standard map prototypes but absent from supplied Amber list =="
python3 - <<'PY'
from pathlib import Path
import re
amber = {
"Captain","HeadOfPersonnel","NanotrasenRepresentative","BlueshieldOfficer",
"Bartender","Botanist","Chef","Janitor","Chaplain","Librarian","ServiceWorker",
"Reporter","RadioHost","ChiefEngineer","AtmosphericTechnician","StationEngineer",
"TechnicalAssistant","ChiefMedicalOfficer","Chemist","MedicalDoctor","Paramedic",
"MedicalIntern","Psychologist","ResearchDirector","Scientist","ResearchAssistant",
"HeadOfSecurity","Warden","SecurityOfficer","Detective","SecurityCadet","Lawyer",
"Quartermaster","SalvageSpecialist","ShaftMiner","CargoTechnician","Passenger",
"Clown","Mime","Musician","StationAi","Borg",
}
counts = {}
for root in ("Resources/Prototypes/Maps", "Resources/Prototypes/_Arcane/Maps"):
for path in Path(root).rglob("*.yml"):
text = path.read_text(encoding="utf-8")
if "type: StationJobs" not in text:
continue
for role in re.findall(r"(?m)^\s{12}([A-Za-z][A-Za-z0-9]*):\s*\[", text):
counts.setdefault(role, set()).add(str(path))
for role in sorted(set(counts) - amber):
print(f"{role}: {len(counts[role])} map(s): {', '.join(sorted(counts[role]))}")
PYLength of output: 9913
# Command
Adjutant: [ 1, 1 ]
CommandMaid: [ 1, 1 ]
# Science
Roboticist: [ 1, 1 ]
# Security
IAA: [ 1, 1 ]
Brigmedic: [ 1, 1 ]
Отдельно: в текущем checkout PR You are interacting with an AI system. |
|
@coderabbitai Причины провала тестов? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== Failed check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Failed job log errors =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 6 '##\[error\]|Unhandled exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|failed|No .* found with id|duplicate|already exists' \
| tail -n 240 || true
doneLength of output: 1336 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== Failed check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Error context from failed runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 5 '##\[error\]|Unhandled exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|No .* found with id|duplicate|already exists|FAILED' \
| tail -n 240 || true
doneLength of output: 1345
Причина в ветке: конфиг Повторная проверка текущих логов не удалась из-за ошибки доступа sandbox к репозиторию, поэтому актуальный статус после последних изменений не подтверждён.
You are interacting with an AI system. |
|
@coderabbitai Снова смотри, а не говори старое. Я пофиксил некоторую часть. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== PR head =="
echo "$sha"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
echo "== Non-successful check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Failed job logs: terminal error context =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 8 \
'##\[error\]|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|No .* found with id|FAILED|failed|Assertion|Expected:' \
| tail -n 280 || true
doneLength of output: 4117 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
job="91690071067"
echo "== Job metadata =="
gh api "repos/$repo/actions/jobs/$job" \
--jq '{name, conclusion, started_at, completed_at, html_url, steps: [.steps[] | {number, name, conclusion}]}'
echo "== Failed log =="
gh run view --repo "$repo" --job "$job" --log-failed 2>&1 \
| tee /tmp/current-debug-build-failure.log
echo "== Error summary =="
rg -in -C 10 \
'##\[error\]|error [A-Z]+[0-9]+:|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|Build FAILED|Process completed with exit code|FAILED' \
/tmp/current-debug-build-failure.log \
| tail -n 260 || trueLength of output: 2088 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
run="30814868592"
job="91690071067"
echo "== Workflow run =="
gh api "repos/$repo/actions/runs/$run" \
--jq '{status, conclusion, event, created_at, updated_at, run_started_at, html_url, cancellation_reason: .cancellation_reason}'
echo "== Job log =="
gh run view "$run" --repo "$repo" --job "$job" --log 2>&1 > /tmp/debug-job.log || true
sed -n '1,20p' /tmp/debug-job.log
echo "== Integration-test context =="
rg -in -C 20 \
'Run Content\.IntegrationTests|Content\.IntegrationTests|cancelled|canceled|timeout|timed out|##\[error\]|Unhandled exception|Exception:|Test Run Failed|FAILED' \
/tmp/debug-job.log \
| tail -n 360 || trueLength of output: 87243
Точная ошибка: В После этого теста job завершился с You are interacting with an AI system. |
|
@coderabbitai Kевее SpawnPointSalvageSpecialist бы поставить, но какие uid выдать? Думаю сразу вставить в прототип карты спавнер |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Box map candidates =="
fd -a -i '^box\.yml$' Resources/Maps Resources 2>/dev/null || true
echo
echo "== Spawn-point entities in Box map candidates =="
fd -a -i '^box\.yml$' Resources/Maps Resources 2>/dev/null \
| while IFS= read -r file; do
echo "-- $file --"
rg -n -i -C 3 'prototype: SpawnPoint(ShaftMiner|SalvageSpecialist)|uid:|entityId:' "$file" || true
done
echo
echo "== Existing SpawnPointShaftMiner and SpawnPointSalvageSpecialist map usage =="
rg -n -i -C 2 'prototype:\s*SpawnPoint(ShaftMiner|SalvageSpecialist)' Resources/Maps 2>/dev/null || trueLength of output: 700
Для исправления текущего теста добавьте именно Повторите проверку после доступного checkout. You are interacting with an AI system. |
|
@coderabbitai Сюда бы в виде вставочного кода в прототип карты ввести майнеров. Накинь вариацию в виде suggestion.
|
|
Tip For best results, initiate chat on the files or code changes.
- proto: SpawnPointShaftMiner
entities:
- uid: 22280
components:
- type: Transform
pos: -37.5,-33.5
parent: 2
- uid: 22281
components:
- type: Transform
pos: -37.5,-34.5
parent: 2
- uid: 22282
components:
- type: Transform
pos: -37.5,-35.5
parent: 2UID You are interacting with an AI system. |
|
@coderabbitai Нам бы особые новые uid для данных точек спавна |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Box map candidates =="
fd -a -i '^box\.yml$' Resources 2>/dev/null || true
echo
echo "== UID statistics and highest UIDs =="
fd -a -i '^box\.yml$' Resources 2>/dev/null \
| while IFS= read -r file; do
echo "-- $file --"
awk '
/^[[:space:]]*- uid:[[:space:]]*[0-9]+[[:space:]]*$/ {
value = $3 + 0
if (value > max) max = value
seen[value]++
}
END {
dupes = 0
for (id in seen) if (seen[id] > 1) dupes++
printf "max_uid=%d, unique_uids=%d, duplicate_uid_values=%d\n", max, length(seen), dupes
}
' "$file"
rg -n -C 3 '^\s*- uid:\s*(222[0-9]{2}|[0-9]{5,})\s*$|prototype:\s*SpawnPoint(ShaftMiner|SalvageSpecialist)' "$file" \
| tail -n 160 || true
doneLength of output: 10186
В этом файле максимальный существующий UID — - proto: SpawnPointShaftMiner
entities:
- uid: 57709
components:
- type: Transform
pos: -37.5,-33.5
parent: 2
- uid: 57710
components:
- type: Transform
pos: -37.5,-34.5
parent: 2
- uid: 57711
components:
- type: Transform
pos: -37.5,-35.5
parent: 2Не используй You are interacting with an AI system. |
|
@coderabbitai Причины провалов тестов? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== PR head =="
printf '%s\n' "$sha"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
echo "== Non-successful check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Failed-run log context =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 12 \
'##\[error\]|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|There is no spawnpoints|No .* found with id|Assertion|Expected:|FAILED|failed|cancelled|canceled|timeout|timed out' \
| tail -n 360 || true
doneLength of output: 1492 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
echo "== PR head =="
printf '%s\n' "$sha"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
echo "== Non-successful check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Failed-run error context =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 10 \
'##\[error\]|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|There is no spawnpoints|No .* found with id|Assertion|Expected:|FAILED|failed|cancelled|canceled|timeout|timed out' \
| tail -n 360 || true
doneLength of output: 1494
Старые данные не повторяю, потому что после ваших изменений они могут быть неверны. Повторите запрос после восстановления доступа sandbox к You are interacting with an AI system. |
|
@coderabbitai Напиши все причины провала тестов. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
pr="168"
sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq '.headRefOid')"
printf 'HEAD=%s\n' "$sha"
echo "== Checks =="
gh pr checks "$pr" --repo "$repo" --json name,state,workflow,link,bucket
echo "== Non-successful check runs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| {id, name, conclusion, details_url, output: {title: .output.title, summary: .output.summary}}'
echo "== Failed job logs =="
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq -r '.check_runs[]
| select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled" or .conclusion == "action_required")
| .details_url' \
| sed -nE 's#.*actions/runs/([0-9]+).*#\1#p' \
| sort -u \
| while IFS= read -r run; do
echo "-- Run $run --"
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 10 \
'##\[error\]|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|There is no spawnpoints|No .* found with id|Assertion|Expected:|FAILED|failed|cancelled|canceled|timeout|timed out' \
| tail -n 500 || true
doneLength of output: 4115 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
run="30836192629"
job="91761842136"
echo "== Failed job metadata =="
gh api "repos/$repo/actions/jobs/$job" \
--jq '{name, conclusion, started_at, completed_at, html_url, steps: [.steps[] | {number, name, conclusion}]}'
echo "== Failed log context =="
gh run view "$run" --repo "$repo" --log-failed 2>&1 \
| rg -in -C 12 \
'##\[error\]|Unhandled exception|System\.[A-Za-z.]+Exception|Exception:|error [A-Z]+[0-9]+:|Build FAILED|Test Run Failed|There is no spawnpoints|No .* found with id|Assertion|Expected:|FAILED|failed|cancelled|canceled|timeout|timed out' \
| tail -n 500 || trueLength of output: 85590 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ArcaneSS14/arcane"
run="30836192629"
gh run view "$run" --repo "$repo" --log > /tmp/pr168-run.log
echo "== Pair 5 and client termination context =="
rg -in -C 20 \
'pair 5|TestBaseTurfRecursion|client.*(killed|crash|exit|disconnect)|server.*(killed|crash|exit)|fatal|critical|unhandled|exception|segmentation|out of memory|oom|assert' \
/tmp/pr168-run.log \
| sed -n '1,900p'
echo "== Test results in execution order =="
rg -n \
'^\S+.*(Failed|Passed|Skipped) [A-Za-z0-9_.]+\s*\[' \
/tmp/pr168-run.log \
| tail -n 100Length of output: 169507
После второго сбоя test pool перестал работать. Поэтому ещё 19 тестов упали каскадно с: Каскадные сбои включают
You are interacting with an AI system. |
20 participants
Описание PR
Чуть не залил через мастер.
Медиа
Тип PR
Лицензионное соглашение
Изменения