Dev 0.5.11 - #198
Merged
Merged
Conversation
…tsv-with-decode Feat/handle auto determine tsv with decode
…sassy Dep/handle n fraction with sassy
…ions Fix/case insensitive extensions
Dep/update dependencies
…utput Fix/graceful error on bam output
…or-on-bam-output Revert "Fix/graceful error on bam output"
…utput fix: correctly fix output format detection and bail
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for controlling the maximum fraction of ambiguous N bases allowed in fuzzy matches via a new --max-n-frac CLI option. It refactors the fuzzy matching logic across grep and split commands to use a centralized build_fuzzy_searcher helper, which validates uniform pattern lengths to prevent panics and applies the max_n_frac filter. Additionally, it updates file format inference to support TSV/TXT extensions case-insensitively, explicitly rejects BAM output, adds an install recipe to the justfile, and includes comprehensive unit tests for the new functionality. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.