Revert "Fix/graceful error on bam output" - #196
Merged
noamteyssier merged 1 commit intoJul 20, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces a direct bail! macro call with a fully-qualified anyhow::bail! call in src/cli/output.rs and removes the test_decode_bam_output_rejected test in src/commands/decode/mod.rs. The reviewer suggested reverting the change to anyhow::bail! and using the simpler bail! macro instead, as it is already imported in the file.
| return Ok(format); | ||
| } | ||
| bail!("Could not infer file format.") | ||
| anyhow::bail!("Could not infer file format.") |
There was a problem hiding this comment.
Since bail is already imported from anyhow on line 1, you can use bail! directly instead of the fully-qualified anyhow::bail! to maintain consistency and readability.
Suggested change
| anyhow::bail!("Could not infer file format.") | |
| bail!("Could not infer file format.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #195