feat(Mutual Checker): update "follows you!" icon - #2349
Open
AprilSylph wants to merge 3 commits into
Open
Conversation
- if mutuals, `fill` is required but `style` is not - if not mutuals, `style` is required but `fill` is not - `viewBox: '0 0 1000 1000'` is misleading for non-mutual case
AprilSylph
marked this pull request as ready for review
August 24, 2026 15:02
marcustyphoon
approved these changes
Aug 24, 2026
marcustyphoon
left a comment
Collaborator
There was a problem hiding this comment.
I think it will be possible to make an elegant system that does allow icons to be used that aren't a feature's primary icon, but this is an improvement anyway.
Collaborator
|
Okay, too messy to make an inline suggestion, but: the parentheses around the svg() calls seem unnecessary. edit: Ah, eslint indents them in a weird way, I see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the "follows you!" blog card icon to one of Tumblr's design system icons.
I believe this is the one usage of
buildSvgthat doesn't just use the same icon that's used for the feature in the control panel; removing this usage getsbuildSvgcloser to how I'm envisioning it would work in a world where we don't commitremixicon.symbol.svg.This shouldn't change how the mutual icon renders at all.
Screenshots
Testing steps