Skip to content

feat(Mutual Checker): update "follows you!" icon - #2349

Open
AprilSylph wants to merge 3 commits into
masterfrom
aprilsylph/ds-user-following-outline
Open

feat(Mutual Checker): update "follows you!" icon#2349
AprilSylph wants to merge 3 commits into
masterfrom
aprilsylph/ds-user-following-outline

Conversation

@AprilSylph

@AprilSylph AprilSylph commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Description

Updates the "follows you!" blog card icon to one of Tumblr's design system icons.

I believe this is the one usage of buildSvg that doesn't just use the same icon that's used for the feature in the control panel; removing this usage gets buildSvg closer to how I'm envisioning it would work in a world where we don't commit remixicon.symbol.svg.

This shouldn't change how the mutual icon renders at all.

Screenshots

Before After Before After
Screenshot 2026-08-24 at 3 46 09鈥痯m Screenshot 2026-08-24 at 3 46 19鈥痯m Screenshot 2026-08-24 at 3 46 32鈥痯m Screenshot 2026-08-24 at 3 46 44鈥痯m

Testing steps

  1. Load the modified addon
  2. Enable Mutual Checker
  3. Find a post from a mutual
    • Expected result: The mutual icon is still inserted into the post header as normal
    • Expected result: Hovering the mutual icon shows the usual "Mutuals" hovertext
  4. Hover a mutual's avatar
    • Expected result: The mutual icon is still inserted into the blog card as normal
    • Expected result: Hovering the mutual icon shows the usual "Mutuals" hovertext
  5. Hover a follower's avatar
    • Expected result: The Tumblr following icon is inserted into the blog card
    • Expected result: Hovering the following icon shows the usual "{blogName} follows you!" hovertext

- if mutuals, `fill` is required but `style` is not
- if not mutuals, `style` is required but `fill` is not
- `viewBox: '0 0 1000 1000'` is misleading for non-mutual case
@AprilSylph
AprilSylph marked this pull request as ready for review August 24, 2026 15:02

@marcustyphoon marcustyphoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be possible to make an elegant system that does allow icons to be used that aren't a feature's primary icon, but this is an improvement anyway.

Comment thread src/features/mutual_checker/index.js
@marcustyphoon

marcustyphoon commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Okay, too messy to make an inline suggestion, but: the parentheses around the svg() calls seem unnecessary.

edit: Ah, eslint indents them in a weird way, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants