refactor: use new element shorthands in modules using buildSvg() - #2348
Merged
Conversation
Owner
Author
|
...I just realised I left the |
Collaborator
|
Oh yeah, I guess "remove every use of the dom util" was one of the potential answers for that question I dm'd you about potential stuff you might want me to execute. |
Owner
Author
|
I still think the best way to go about removing |
marcustyphoon
approved these changes
Aug 24, 2026
Collaborator
|
Not sure if "E shorthands" is the most clear title; I had no idea what that referred to :D |
Owner
Author
|
Yeah, I was just trying to get the commit title down to a good character length, but then got lazy on the PR title just copying the commit title wholesale. Will update. |
E shorthands in modules using buildSvg()buildSvg()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to optimise
lib/remixicon.symbol.svgaway, which means drastically changing whatbuildSvgdoes. However, most of the usages ofbuildSvgare nested insidedom()calls, which I just can't abide. Not to mention,buildSvgusesdom()itself! Oh, the horror!So, no more
dom()andbuildSvgin the same files. This is its own PR so that it can be tested separately from any actual changes tobuildSvg.Screenshots
No visual changes expected.
Testing steps
Load the modified addon, and smoke-test all the features affected: