Skip to content

refactor: use new element shorthands in modules using buildSvg() - #2348

Merged
AprilSylph merged 3 commits into
masterfrom
aprilsylph/build-icon-element
Aug 24, 2026
Merged

refactor: use new element shorthands in modules using buildSvg()#2348
AprilSylph merged 3 commits into
masterfrom
aprilsylph/build-icon-element

Conversation

@AprilSylph

Copy link
Copy Markdown
Owner

Description

I'm trying to optimise lib/remixicon.symbol.svg away, which means drastically changing what buildSvg does. However, most of the usages of buildSvg are nested inside dom() calls, which I just can't abide. Not to mention, buildSvg uses dom() itself! Oh, the horror!

So, no more dom() and buildSvg in the same files. This is its own PR so that it can be tested separately from any actual changes to buildSvg.

Screenshots

No visual changes expected.

Testing steps

Load the modified addon, and smoke-test all the features affected:

  • Mutual Checker (verify: mutuals icon, follower icon)
  • Quick Tags (verify: post control button, post form button)
  • Quote Replies
  • Trim Reblogs

@AprilSylph

Copy link
Copy Markdown
Owner Author

...I just realised I left the xmlns properties intact. Those aren't necessary anymore.

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Oh yeah, I guess "remove every use of the dom util" was one of the potential answers for that question I dm'd you about potential stuff you might want me to execute.

@AprilSylph

Copy link
Copy Markdown
Owner Author

I still think the best way to go about removing dom() calls is "as needed". I wouldn't review a PR that only does it for its own sake, i.e. not as a precursor to something we actually want to do.

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Not sure if "E shorthands" is the most clear title; I had no idea what that referred to :D

@AprilSylph

Copy link
Copy Markdown
Owner Author

Yeah, I was just trying to get the commit title down to a good character length, but then got lazy on the PR title just copying the commit title wholesale. Will update.

@AprilSylph AprilSylph changed the title refactor: use E shorthands in modules using buildSvg() refactor: use new element shorthands in modules using buildSvg() Aug 24, 2026
@AprilSylph
AprilSylph merged commit 7f5ec4c into master Aug 24, 2026
5 checks passed
@AprilSylph
AprilSylph deleted the aprilsylph/build-icon-element branch August 24, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants