feat(AccessKit Disable GIFs): Implement native tumblr media pausing compatibility - #2270
feat(AccessKit Disable GIFs): Implement native tumblr media pausing compatibility#2270marcustyphoon wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Ah, interesting: this isAnimated check doesn't work in blog view now (but does work outside of it). Race condition, I guess. (The only difference I know of is that blog view images aren't loading=lazy, and I don't see why that would cause this).
I guess the correct behavior would be to... assume that all webp images that are clickable are animated? Hm, but currently we click the image in a separate part of the code. That's annoying.
There was a problem hiding this comment.
Aha, subtlety when solving this: the third image in https://www.tumblr.com/uyallstars/808763769014681600/pok%C3%A8mon-the-movie-2000 has the url https://44.media.tumblr.com/e1e034a13feb0825b20e5c3acb2d3424/999f368947654671-e8/s540x810_f1/0f8607b0a0a85332b5aaa7e0c76beb87844aaf07.gifv when paused, but is a .webp when unpaused.
There was a problem hiding this comment.
marcustyphoon@48678c9 write code, they said. it'll be fun, they said.
There was a problem hiding this comment.
Implemented, with the caveat that this inherits Tumblr's erroneous "treat it like it's animated" behavior on non-animated webp images when media autoplay is disabled. I just sent a support message about that.
Description
This makes the AccessKit Disable GIFs feature override the Tumblr "disable media autoplay" feature if it's enabled. Resolves #2247.
Currently this does not address #2243: the "download paused gifs [immediately/on hover]" setting remains inoperative, equivalent to selecting "immediately."
Screenshots
disable-gifs-new.mov
Testing steps