Skip to content

feat(AccessKit Disable GIFs): Implement native tumblr media pausing compatibility - #2270

Open
marcustyphoon wants to merge 5 commits into
masterfrom
marcustyphoon/disable-gifs-native-compat
Open

feat(AccessKit Disable GIFs): Implement native tumblr media pausing compatibility#2270
marcustyphoon wants to merge 5 commits into
masterfrom
marcustyphoon/disable-gifs-native-compat

Conversation

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Description

This makes the AccessKit Disable GIFs feature override the Tumblr "disable media autoplay" feature if it's enabled. Resolves #2247.

Currently this does not address #2243: the "download paused gifs [immediately/on hover]" setting remains inoperative, equivalent to selecting "immediately."

Screenshots

disable-gifs-new.mov

Testing steps

  • Set the "media auto-play" setting in https://www.tumblr.com/settings/dashboard to "never", or to "use system" with your operating system set to reduce motion.
  • Open a page like https://www.tumblr.com/search/gif/recent. Enable AccessKit Disable GIFs and confirm that posts stay paused, but switch to the XKit GIF labels, and that they immediately animate when moused over.
  • Open a page like https://www.tumblr.com/search/gif/recent with AccessKit Disable GIFs already enabled and confirm that posts stay paused, switching quickly to the XKit GIF labels, and that they immediately animate when moused over.
  • Repeat the above with webp images, like on https://www.tumblr.com/tagged/webp.
  • Enable sufficient throttling in browser dev tools to observe this. Open a page like https://www.tumblr.com/search/gif/recent, scroll down, and confirm that this is the precise sequence of events when a gif (not a webp, unfortunately) is loaded:
    • The gradient placeholder appears, with a loading icon in the top right.
    • The stationary image appears, with an AccessKit GIF label in the top right, with no loading icon visible beneath it. If the image is hovered during this stage, the AccessKit GIF label disappears and is replaced with a loading icon in the top right.
    • Fully loaded: if not hovered, the stationary image appears, with an AccessKit GIF label in the top right. If hovered, the animated image appears, with nothing in the top right.

Comment thread src/features/accesskit/disable_gifs.js Outdated

@marcustyphoon marcustyphoon Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting: this isAnimated check doesn't work in blog view now (but does work outside of it). Race condition, I guess. (The only difference I know of is that blog view images aren't loading=lazy, and I don't see why that would cause this).

I guess the correct behavior would be to... assume that all webp images that are clickable are animated? Hm, but currently we click the image in a separate part of the code. That's annoying.

@marcustyphoon marcustyphoon Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marcustyphoon@48678c9 write code, they said. it'll be fun, they said.

@marcustyphoon marcustyphoon Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented, with the caveat that this inherits Tumblr's erroneous "treat it like it's animated" behavior on non-animated webp images when media autoplay is disabled. I just sent a support message about that.

@marcustyphoon marcustyphoon self-assigned this Jun 10, 2026
@marcustyphoon
marcustyphoon removed the request for review from AprilSylph June 10, 2026 08:49
@marcustyphoon marcustyphoon removed their assignment Jun 10, 2026
@marcustyphoon

marcustyphoon commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

@marcustyphoon marcustyphoon changed the title feat(AccessKit): Implement native tumblr media pausing compatibility feat(AccessKit Disable GIFs): Implement native tumblr media pausing compatibility Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccessKit Disable GIFs: Feature doesn't override Tumblr's GIF pausing

1 participant