Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes references to "운세" (fortune-telling) from the app's user-facing text and branding to address Apple App Store rejection. The app is being rebranded from "운세한장" to "오늘한장".
Changes:
- Updated app name and display names from "운세한장" to "오늘한장" in configuration
- Revised onboarding screen text to remove fortune-telling terminology
- Bumped app version from 1.0.6 to 1.0.8
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app.config.ts | Updated app name, display names, and version number |
| src/components/Onboarding.tsx | Replaced fortune-telling terminology with neutral wording in onboarding screens |
Comments suppressed due to low confidence (1)
src/components/Onboarding.tsx:100
- This onboarding step still contains references to '운세' (fortune-telling) which contradicts the purpose of this PR. These should be updated to match the new branding without fortune-telling terminology.
description={'운세는 오늘까지 제공돼요.\n미래의 운세는 미리 확인할 수 없어요.'}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title={'뜯어서 확인하는\n오늘의 운세'} | ||
| description={'일력 상단을 드래그하여 일력을 뜯으면\n오늘의 총평을 확인할 수 있어요.'} | ||
| title={'뜯어서 확인하는\n오늘의 한마디'} | ||
| description={'일력 상단을 드래그하여 일력을 뜯으면\n오늘의 한마디 확인할 수 있어요.'} |
There was a problem hiding this comment.
Missing particle '를' after '한마디'. Should be '오늘의 한마디를 확인할 수 있어요.'
Suggested change
| description={'일력 상단을 드래그하여 일력을 뜯으면\n오늘의 한마디 확인할 수 있어요.'} | |
| description={'일력 상단을 드래그하여 일력을 뜯으면\n오늘의 한마디를 확인할 수 있어요.'} |
| render: () => ( | ||
| <Step3Visual | ||
| title={'스크롤로 보는\n상세 운세'} | ||
| title={'스크롤로 보는\n 행동 가이드'} |
There was a problem hiding this comment.
Unnecessary leading space before '행동 가이드'. Should be '스크롤로 보는\n행동 가이드'.
Suggested change
| title={'스크롤로 보는\n 행동 가이드'} | |
| title={'스크롤로 보는\n행동 가이드'} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내용
애플 리젝 사유에 "운세"가 포함되어 제거하는 작업 진행했습니다