Conversation
Three gaps left over from the social card work, all visible whenever
someone posts a wiki link in Discord.
97 pages carried no description at all. They have no `description` in
their front matter, and `site_description` was never set, so the fallback
resolved to nothing and the embed printed a bare title. That was
survivable when the card was a full-width banner with its own text. Now
that the image is a small generic mark, the description carries the page,
so add a site-wide sentence for those pages to fall back to.
Add `og:site_name`, so the small provider line above the title reads
"Apollo Docs" instead of the raw wiki.apolloautomation.com. With that in
place the " - Apollo Docs" suffix on every title repeats the line directly
above it, so drop the suffix and give the title the full width before it
truncates. The homepage still resolves to "Apollo Docs" once.
Add a `theme-color` tag, which Discord uses to tint the stripe down the
left edge of an embed and which Android uses to tint browser chrome. The
stripe is drawn on every embed regardless; without this tag it is
Discord's default grey. Material emits no such tag here because the
palette uses a custom primary rather than a named color. It has to be
`name=` rather than `property=`, so it cannot come from the card layout,
which hardcodes `property=` for everything. It goes in overrides/main.html
instead. Material's stock main.html is a bare `{% extends "base.html" %}`,
so overriding it drops nothing.
Verified by building all three page shapes and reading the emitted tags: a
page with its own description keeps it, a page without one picks up the
new fallback, and the homepage title does not double or empty out.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes #1090 to the live wiki.
🤖 Generated with Claude Code