Skip to content

Silence the strapping pin warnings on the GPIO4 and GPIO5 buttons - #24

Merged
bharvey88 merged 1 commit into
betafrom
fix/silence-strapping-warnings
Aug 31, 2026
Merged

Silence the strapping pin warnings on the GPIO4 and GPIO5 buttons#24
bharvey88 merged 1 commit into
betafrom
fix/silence-strapping-warnings

Conversation

@bharvey88

Copy link
Copy Markdown
Contributor

Version: 26.8.27.1

What does this implement/fix?

Every build opens with four strapping pin warnings:

WARNING GPIO4 is a strapping PIN and should only be used for I/O with care.
WARNING GPIO5 is a strapping PIN and should only be used for I/O with care.
WARNING GPIO5 is a strapping PIN and should only be used for I/O with care.
WARNING GPIO4 is a strapping PIN and should only be used for I/O with care.

GPIO4 and GPIO5 are the Song Button 2 and Song Button 3 pins, and each warns twice because each is declared under deep_sleep's esp32_ext1_wakeup and again on its binary_sensor. The warning is about attaching external pullups or pulldowns to a strapping pin. Both buttons run on the C6's internal pulldowns, so it doesn't apply. GPIO9's reset button already carries ignore_strapping_warning: true for the same reason.

This adds the flag to all four declarations. esphome config on H-3.yaml and H-3D.yaml is now warning free, which makes a real warning visible when one shows up.

No version bump. ignore_strapping_warning is read by the pin validator and never passed to codegen, so the compiled firmware is byte for byte what it was.

Touches the same file as #23 but not the same lines, so the two are independent.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Validated against esphome 2026.8.1 on both variants, zero warnings out.

🤖 Generated with Claude Code

GPIO4 and GPIO5 are the Song Button 2 and Song Button 3 pins, and each warns
twice at the top of every build because each is declared under deep_sleep's
esp32_ext1_wakeup and again on its binary_sensor.

The warning is about external pullups or pulldowns on a strapping pin. Both
buttons run on the C6's internal pulldowns, so it does not apply. GPIO9's
reset button already carries the same flag.

No version bump: ignore_strapping_warning is read by the pin validator and
never passed to codegen, so the compiled firmware is unchanged.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 56ba0e36-ac65-492d-8350-4e13893395d0


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88
bharvey88 merged commit b5c9b52 into beta Aug 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant