Silence the strapping pin warnings on the GPIO4 and GPIO5 buttons - #24
Merged
Conversation
GPIO4 and GPIO5 are the Song Button 2 and Song Button 3 pins, and each warns twice at the top of every build because each is declared under deep_sleep's esp32_ext1_wakeup and again on its binary_sensor. The warning is about external pullups or pulldowns on a strapping pin. Both buttons run on the C6's internal pulldowns, so it does not apply. GPIO9's reset button already carries the same flag. No version bump: ignore_strapping_warning is read by the pin validator and never passed to codegen, so the compiled firmware is unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.8.27.1
What does this implement/fix?
Every build opens with four strapping pin warnings:
GPIO4 and GPIO5 are the Song Button 2 and Song Button 3 pins, and each warns twice because each is declared under
deep_sleep'sesp32_ext1_wakeupand again on itsbinary_sensor. The warning is about attaching external pullups or pulldowns to a strapping pin. Both buttons run on the C6's internal pulldowns, so it doesn't apply. GPIO9's reset button already carriesignore_strapping_warning: truefor the same reason.This adds the flag to all four declarations.
esphome configonH-3.yamlandH-3D.yamlis now warning free, which makes a real warning visible when one shows up.No version bump.
ignore_strapping_warningis read by the pin validator and never passed to codegen, so the compiled firmware is byte for byte what it was.Touches the same file as #23 but not the same lines, so the two are independent.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Validated against esphome 2026.8.1 on both variants, zero warnings out.
🤖 Generated with Claude Code