Skip to content

Update Since Deprecated - #22

Merged
TrevorSchirmer merged 1 commit into
betafrom
FixRGBOrder
Aug 28, 2026
Merged

Update Since Deprecated#22
TrevorSchirmer merged 1 commit into
betafrom
FixRGBOrder

Conversation

@TrevorSchirmer

@TrevorSchirmer TrevorSchirmer commented Aug 28, 2026

Copy link
Copy Markdown
Member

Version:

What does this implement/fix?

  • Switches to channel_colors

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Bug Fixes
    • Updated LED strip color channel configuration to maintain correct GRB color rendering with the latest ESPHome settings.

@github-actions github-actions Bot added the bugfix Something isn't working label Aug 28, 2026
@github-actions
github-actions Bot requested a review from bharvey88 August 28, 2026 03:32
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b025639-b53d-4972-8135-c388a4e12404

📥 Commits

Reviewing files that changed from the base of the PR and between 4e89660 and c81aa73.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The ESPHome led_chain configuration now uses channel_colors: GRB instead of the deprecated rgb_order: grb syntax.

Changes

ESPHome LED Configuration

Layer / File(s) Summary
Update LED channel color syntax
Integrations/ESPHome/Core.yaml
The led_chain light replaces rgb_order: grb with channel_colors: GRB and preserves the GRB channel order.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c81aa

This localized configuration update switches the LED color-order setting to the newer syntax while preserving existing GRB behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: bharvey88, bunton33

Poem

A rabbit checks the glowing chain,

GRB still leads the color train.
The old key hops away,
The new key lights the way,
ESPHome shines clear again.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title refers to a deprecated setting, but it does not clearly identify the switch from rgb_order to channel_colors for ESPHome LED strip configuration. Use a specific title such as Replace deprecated rgb_order with channel_colors.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch FixRGBOrder

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TrevorSchirmer
TrevorSchirmer merged commit d28922d into beta Aug 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants