Make All Lights a master over the zones instead of raw pixels

[bharvey88]

Version: 26.8.27.1

What does this implement/fix?

The All Lights entity added in #17 spanned pixels 0-36, which are the same pixels the five zone lights own. Two independent LightState objects, no reconciliation. Turn on All Lights, turn on Body Light, then turn All Lights off, and Body either stays physically lit (an effect selected on it repaints 0-23 on its own interval) or goes dark while its entity still reports on.

Rebuilds the master on partition's other segment form. single_light_id accepts any light (partition/light.py:69 is cv.use_id(light.LightState)), so the master wraps the five zone lights instead of a pixel range:

  - platform: partition
    id: all_lights
    name: "All Lights"
    segments:
      - single_light_id: body_light
      - single_light_id: mouth_light
      - single_light_id: nose_light
      - single_light_id: eyes_light
      - single_light_id: hat_light

AddressableLightWrapper was built for this. Its write_state() opens with:

    // Don't overwrite state if the underlying light is turned on
    if (this->light_state_->remote_values.is_on()) {
      this->mark_shown_();
      return;
    }

so a zone the user turned on is never painted over by the master. When the master does drive a zone it uses call.set_publish(false) and call.set_save(false), so a master-driven zone never falsely reports on in Home Assistant. Both failure modes above go away.

The cleanup wiring from #17 is deliberately kept. all_lights_off, both on_shutdown blocks and each play_song_* still clear the master. Dropping the all_lights_off line in particular would let a master left on repaint the zones after a song ends, leaving the ornament lit.

Trade-off

AddressableLightWrapper::size() returns 1, one pixel per wrapped light, so the master sees a five-pixel strip rather than 37. Solid color and brightness across the whole ornament, which is what the entity exists for, work exactly as before. An effect selected on All Lights now renders as five blocks, one per zone, instead of a smooth 37-LED gradient. Effects selected on an individual zone are unaffected and still address that zone's real pixels.

Types of changes

• Bugfix (fixed change that fixes an issue)
• New feature (thanks!)
• Breaking change (repair/feature that breaks existing functionality)
• Dependency Update - Does not publish
• Other - Does not publish
• Website of github readme file update - Does not publish
• Github workflows - Does not publish

Checklist / Checklijst:

• The code change has been tested and works locally
• The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

• Added/updated documentation for the web page

esphome config passes on both H-3.yaml and H-3D.yaml, and the merged config shows the master with its five wrapped segments. Not yet tested on hardware.

Conflicts with #20 on the version substitution and the all_lights block. Whichever merges second needs a merge from beta.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a01cd343-1b94-4754-9c80-7d084f97a253

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}