Fix beta asset publish and repoint the beta-fw tag - #13
Merged
Conversation
The publish job never found the firmware it had just downloaded:
find: 'fw/firmware-standard': No such file or directory
Error: manifest.json not found for firmware-standard
actions/download-artifact only creates a per-artifact subdirectory when
two or more artifacts match the pattern. With exactly one match it
extracts flat into `path`:
Total of 1 artifact(s) downloaded
Starting download of artifact to: /home/runner/work/H-3/H-3/fw
H-3 builds a single beta image, since H-3D has no wifi or OTA and is
USB-flash only, so the files landed in fw/ while the publish step looked
in fw/firmware-standard/. The rest of the fleet builds two beta images
and always gets the subdirectory, which is why the same script works
there. Downloading by name instead of pattern pins the layout regardless
of artifact count.
Also adds the beta-fw tag repoint step that MSR-1 and CAST-1 already
have. Without it the release tag tracks main HEAD rather than the beta
commit that produced the assets; the tag currently points at main.
The beta-fw release has no assets at all right now, so a device switched
to the Beta channel gets a 404 on the manifest until this lands.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.8.23.1
What does this implement/fix?
The
publish-betajob fails on every push tobeta, so thebeta-fwrelease has never received any assets. A device switched to the Beta
channel gets a 404 on the manifest today.
actions/download-artifactonly creates a per-artifact subdirectorywhen two or more artifacts match the pattern. With exactly one match it
extracts flat into
path:H-3 builds a single beta image, because H-3D has no wifi or OTA and is
USB-flash only. So the files landed in
fw/while the publish steplooked in
fw/firmware-standard/. MSR-1 and CAST-1 build two betaimages and always get the subdirectory, which is why the same script
works there. Downloading by name instead of pattern pins the layout
regardless of artifact count.
Also adds the
Point beta-fw tag at the built commitstep that MSR-1and CAST-1 already have, byte-identical to theirs. Without it the
release tag tracks
mainHEAD rather than the beta commit that producedthe assets.
gh api repos/ApolloAutomation/H-3/releases/tags/beta-fwcurrently reports
"target": "main".Unblocks #11.
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code