Trim verbose comments in the device YAML - #78
Merged
Conversation
Cuts the comment blocks down to the non-obvious facts and drops comments that restate the identifier below them. Three corrections beyond the trim: - Move the BT PSRAM comment into the sdkconfig block, above CONFIG_BT_ALLOCATION_FROM_SPIRAM_FIRST, instead of leaving it above esp32_ble_tracker where it read as describing the tracker. - Reword the resampler stack comment as a "must", since it guards the deliberate absence of task_stack_in_psram rather than a setting present in the file. - Drop the commented-out decode_memory line, which parked a disabled option in the config instead of stating a fact. Comments only. esphome config validates unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same pass as Core.yaml, applied to the other two device YAMLs. CAST-1.yaml's header repeated the Ethernet preference that Core.yaml now states at the network block; what is left names the file and points at Core.yaml. wizmote.yaml's channel-scan block reduces to the rule it guards. Comments only. esphome config validates unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
bharvey88
changed the title
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 26.8.28.1
What does this implement/fix?
Core.yaml,CAST-1.yamlandwizmote.yamlto the non-obvious facts, and drops comments that restate the identifier below themCONFIG_BT_ALLOCATION_FROM_SPIRAM_FIRST, where it had been sitting aboveesp32_ble_trackerand reading as if it described the trackertask_stack_in_psramrather than a setting present in the filedecode_memoryline, which parked a disabled option in the configComments only, no behavior change.
esphome configvalidates.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code