Make tests runnable on Windows and with newer h5dump, with related fixes#160
Open
marklam wants to merge 1 commit into
Open
Make tests runnable on Windows and with newer h5dump, with related fixes#160marklam wants to merge 1 commit into
marklam wants to merge 1 commit into
Conversation
…xes. - Add SharedHdf5StateCollection to serialize tests using HDF5/global state, preventing failures from sharing problems. - Update xUnit dependencies and add Xunit.SkippableFact for conditional test skipping. - Fix FilePathUtils handling of Widnows environment variables. - Make TestUtils.DumpH5File work with newer h5dump. - Use 'using' for H5File in tests to prevent attempts to delete in-use files. - Add .AsSpan() to fix build problem in .net 10 sdk. - Handle 16-byte types in filter tests with opaque type for portability (because LDOUBLE is 8 bytes in Windows). - Make HSDS Skip (not fail) if server is unreachable. - Fix a chunked storage encoding problem reported by h5dump 2.1. - Dispose VirtualDatasetStream in H5D_Virtual (tests failed when the files couldn't be replaced).
Owner
|
Thanks for your PRs, I hope to be able to review soon. Regarding |
Contributor
Author
|
I think it is that problem. This PR changes the vaue written to be what h5dump 2.1.1 was happy with. I can back that bit out if you'd prefer. |
Owner
|
No, it is fine for now. When I do the review I will or will not request a change. I am not sure if I can do the review soon but I will do my best to work in it in the coming days. |
Contributor
Author
|
No problem! I've created a few PRs but tried to keep them orthogonal to make more "bite sized" work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the tests work on Windows, and compatible with .net 10 sdk and a newer h5dump.
It fixes some problems with test parallelism and inability to delete files due to un-garbage-collected handles.