fix: increase MAX_SIG_STRUCTURE_SIZE to 8192#5
Conversation
CapCut/Bytedance videos have sig_structure of 5241 bytes (RSA-4096 intermediate chain), exceeding the 5120 limit. Increase to 8192 to accommodate RSA-4096 chains and future enterprise 4-cert chains. sha256_var only hashes actual bytes, so unused buffer costs zero constraints — only signers with larger chains pay the extra cost. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree Noir modules increased the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
MAX_SIG_STRUCTURE_SIZEfrom 5120 to 8192 in all 3 proof_b circuitsRationale
8192 chosen to handle:
sha256_var()only hashes actual bytes — unused buffer costs zero constraints. Only signers with larger chains pay extra proving cost.Test plan
nargo compile🤖 Generated with Claude Code
Summary by CodeRabbit