chore: move Main.DrawSettings -> `.HumanModel.DrawSettings - #180
Open
bkje14 wants to merge 32 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BodyModelhad a lot of absolute paths to the defaultDrawSettings. This and the location of the drawsettings directly insideMaincreates issues when wanting to include two humans in a model. Furthermore, Drawsettings are primarily for the HumanModel.This PR moves the default settings to
HumanModel.DrawSettings.The old location is marked as deprecated and can be switched on using the
BM_COMPATIBILITY_BODYMODEL_STRUCTUREparameter.The two BM parameters
BM_DRAWSETTINGS_FILEandBM_DRAWSETTINGS_SKIPas they are no longer needed.The default drawsettings are implemented with the
??=optional operator (since AMMR2).The
BM_DRAWSETTINGS_SKIPwas a temporary workaround to allow two humans in one model.