chore: remove AnyDrawRefFrame classes - #179
Conversation
mdabt
left a comment
mdabt
left a comment
There was a problem hiding this comment.
Some general comments
- Are all the shown RefFrames really needed? Maybe more a question for ST and co.
- Is the in-one-line setting ok? I like it for this draw specs, but this PR suggests a few places with multiline (which I propose to in one line too)
- ScaleXYZ (typically set to 0.1) - Is it needed with current view RefFrame's default. If it is needed maybe it ought to be a shared DrawSetting
| sRel = .Scale(.DistalCyl[1])*.Mirror; | ||
| viewRefFrame = { | ||
| Visible = On; | ||
| ScaleXYZ = {1,1,1}*0.1; |
There was a problem hiding this comment.
I wonder if this is really needed with viewRefFrame's defaults.
I also wonder why we need to see PalmarCylNode1 in SoftTissue. @st?
| AnyRefNode acj = { sRel = .Scale(.Data.acj_pos*.Mirror); #include "../DrawSettings/JointAxesDistal.any" }; | ||
| AnyRefNode scj = { sRel = .Scale(.Data.scj_pos*.Mirror); #include "../DrawSettings/JointAxesProximal.any" }; | ||
| AnyRefNode scj = { sRel = .Scale(.Data.scj_pos*.Mirror);}; |
There was a problem hiding this comment.
Not sure I get why DrawSettings are removed!
And only in some places, but not the first
There was a problem hiding this comment.
The JointAxesProximal.any was a empty file. That is why only that one is removed.
| viewRefFrame = { | ||
| Visible = On; | ||
| RGB = {0,1,0}; | ||
| ScaleXYZ = 0.2*{0.05,0.05,0.05}; |
| // }; | ||
| AnyRefNode FDB3_Via2 = { | ||
| sRel = .Scale({-0.01205038, -0.0572402, ....Sign*0.02281839}); | ||
| AnyDrawNode drw = { |
There was a problem hiding this comment.
Many AnyDrawNode objects. I guess they do not have a viewNode-option in AnyBody - but they should
There was a problem hiding this comment.
I left them for now, to only focus on AnyDrawRefFrame.
But I saw AnyDrawNode, AnyDrawSurf and maybe some others that could came the same treatment.
|
|
||
| //AnyDrawSeg Draw = {}; | ||
| //AnyDrawRefFrame Drw = {ScaleXYZ={1,1,1}*0.1;}; |
There was a problem hiding this comment.
More lines to delete, I guess. AnyDrawSeg and AnyDrawNodes
| PelvisNode={AnyDrawRefFrame drw={RGB={1,0,0};Visible = Off;}; }; | ||
| ThighNode={AnyDrawRefFrame drw={RGB={0,1,0};Visible = Off;}; }; | ||
| PelvisNode = {viewRefFrame = { RGB = {1,0,0}; Visible = Off;}; }; | ||
| ThighNode = {viewRefFrame = { RGB = {0,1,0}; Visible = Off;}; }; |
| AnyRefNode &ref2 = ....layer_above.LayerConstraintNodes.Nodes_Below_Layer._node0001; | ||
| Ref=0; | ||
| #ifdef _ABDOMINAL_VISUALIZE_FOR_DEBUG | ||
| AnyDrawPLine drw ={Thickness=0.0025;}; |
There was a problem hiding this comment.
Are these (many in this file) missing a Visible = On?
2 participants
With many of the classes supporting default drawing objects this PR is about removing old draw objects.
AnyDrawRefFrameAnyDrawRefFrame->viewRefFrame