Skip to content

feat: Check if MoCap marker cutoff freq is too low - #151

Draft
divyaksh-chander wants to merge 4 commits into
ammr4-betafrom
MoCapCutOffFreqCheck
Draft

feat: Check if MoCap marker cutoff freq is too low#151
divyaksh-chander wants to merge 4 commits into
ammr4-betafrom
MoCapCutOffFreqCheck

Conversation

@divyaksh-chander

@divyaksh-chander divyaksh-chander commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Add a check in the marker driver class template that compares the position of raw marker data and filtered marker data. A large error indicates that cut off frequency is too low.

A warning will be given to the user indicating the marker and the max error for the marker in the entire motion.

However, the warning can also be raised for issues in marker labelling, for example marker flipping, drop out.

To do:

  • Decide on default threshold. Current feeling is 2 cm.
  • Option to customize the threshold somehow?
  • Changelog entry.

@divyaksh-chander divyaksh-chander changed the title feat: Add a check in marker driver class template to check for error betwee… feat: Check if MoCap marker cutoff freq is too low Apr 1, 2026
@bkje14

bkje14 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

@divyaksh-chander could you check the status of this PR and decide what the next step is - either a review or closure.
It fails the CI on some vnorm dimensionality.

@divyaksh-chander

Copy link
Copy Markdown
Contributor Author

@divyaksh-chander could you check the status of this PR and decide what the next step is - either a review or closure. It fails the CI on some vnorm dimensionality.

I had a look at it. I think it's the updates to AMS that has broken the code. I will try to fix it soon, and pass it on to @toerholm

@divyaksh-chander

Copy link
Copy Markdown
Contributor Author

@divyaksh-chander could you check the status of this PR and decide what the next step is - either a review or closure. It fails the CI on some vnorm dimensionality.

I just had a small review with @toerholm. We will keep it as a draft for now. We must do some testing internally and find the appropriate approach for this concept. We are not so sure about what the threshold should be,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants