fix: ATL-291: raise CommandTimeout for MatchPredictionContext - #1502
Merged
da-ikovalenko merged 1 commit intoAug 12, 2026
Merged
Conversation
CleanupOldParallelMatchPredictionBatches was failing because the DELETE against ParallelMatchPredictionBatches/Runs exceeded the SqlClient/EF Core default 30s CommandTimeout, which was never overridden for the production MatchPredictionContext. Raise it to 10 minutes, matching the existing pattern already used by the Test.Verification and Test.Validation MatchPrediction contexts.
da-ikovalenko
requested review from
OTarasov-DataArt,
SergeySalinAtDataart,
daria-sorokina-da,
pchenery and
roman-sivak-dataart
August 12, 2026 10:17
roman-sivak-dataart
approved these changes
Aug 12, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CleanupOldParallelMatchPredictionBatcheswas timing out because the productionMatchPredictionContextnever overrode the SqlClient/EF Core default 30sCommandTimeout, while the same DELETE routinely needs longer as the batch-cleanup backlog grows.CommandTimeoutto 10 minutes onMatchPredictionContext(Atlas.Functions/Startup.cs,RegisterMatchPredictionDatabase), matching the pattern already used byAtlas.MatchPrediction.Test.Verification.DataandAtlas.MatchPrediction.Test.Validation.Data'sContextFactorys.See ATL-291 for the full root-cause writeup and the fix proposal this implements.
Test plan
dotnet build Atlas.Functions/Atlas.Functions.csproj --configuration Release— 0 errorsCleanupOldParallelMatchPredictionBatchescompletes and clears the backlog (watch App Insights execution duration + the "batch cleanup deleted {Count}" log line)🤖 Generated with Claude Code
This change is