Skip to content

[ACTV-369] Standardize and clarify dismiss behavior in tour dialogs#1302

Merged
r-lelis merged 4 commits into
mainfrom
ACTV-369
Jun 12, 2026
Merged

[ACTV-369] Standardize and clarify dismiss behavior in tour dialogs#1302
r-lelis merged 4 commits into
mainfrom
ACTV-369

Conversation

@r-lelis

@r-lelis r-lelis commented May 28, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed changes

Changes the text and behavior of the tutorial dialog

How to reproduce

  1. Run the tutorials and see that the text of the secodary button changed to Not now
  2. See that the close button only skips the tutorial instead of dismissing it
  3. See that the Don't show again button appears and it dismisses the tutorial, never showing it again

Further comments

#3695 needs to be merged first.

abdnh
abdnh previously approved these changes May 29, 2026
abdnh
abdnh previously approved these changes May 30, 2026
@r-lelis

r-lelis commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@abdnh could you approve this again? I had to update the ankihub submodule commit reference

abdnh
abdnh previously approved these changes Jun 1, 2026
@r-lelis

r-lelis commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@abdnh there was a change on the tour_step, I added a skip method to be called on the continue later button. It's basically to make tour appear again when Anki reopens. Can you take a look?

abdnh
abdnh previously approved these changes Jun 11, 2026
cjasm
cjasm previously approved these changes Jun 11, 2026
@r-lelis r-lelis dismissed stale reviews from cjasm and abdnh via c54dd78 June 11, 2026 17:11
@r-lelis r-lelis merged commit c73e13b into main Jun 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants