Multiple fixed (Sanctify artifacts, 16:10 artifact scanning, auto cons), Feature to partial scan#560
Open
taiwenlee wants to merge 33 commits into
Open
Multiple fixed (Sanctify artifacts, 16:10 artifact scanning, auto cons), Feature to partial scan#560taiwenlee wants to merge 33 commits into
taiwenlee wants to merge 33 commits into
Conversation
taiwenlee
commented
Mar 27, 2025
taiwenlee
commented
Contributor
- fixed issue of sort by obtained not being toggled when scanning
- added shift in bitmaps of artifacts affected by sanctify
- added autos to the potential constellation upgrades for characters (arle, ferm, neuv)
- fixed artifact scanning for 16:10 previously broken by v1.3.17
- partial scan feature lets you scan x amount of pages in artifacts and x amount of characters
feature that lets you scan in recent x pages
for characters such as arle or neuv
also increased rollback frequency for artifacts
8 tasks
|
W, if only this branch would get merged to main lol |
|
I second this. Have a Sethos C5 and he is not exported due to this |
Introduces handling and serialization of unactivated artifact substats in Artifact and ArtifactScraper classes. Updates GOOD export version to 3 and increases character level validation to 100. Adjusts artifact scraping logic and bitmap cropping for improved accuracy.
Updated the AssemblyVersion in AssemblyInfo.cs to 1.4.0 to reflect a new release or significant changes.
Changed all GitHub URLs in MainForm.cs from 'Andrewthe13th' to 'taiwenlee' to reflect fork ownership.
Update install and help links in readme
Adds a check to ensure substats list is not empty before moving the last substat to the unactivated list, preventing potential index errors.
Moved SetSort and ClearFilters calls before item page retrieval to ensure correct sorting and filtering. Added SystemWait calls after filter and sort changes for UI stability. Enhanced substat parsing logic and added debug logging when substats are not found.
Updated the AssemblyVersion in AssemblyInfo.cs from 1.4.0.* to 1.4.1.* to reflect a new version release.
Fixed error when building for the first time
Manequin fix looks fine to me...
Updated the Rectangle region calculation to use consistent values for x, width, and height, and adjusted the y value for non-normal navigation. Fix 16:10 res scanning.
Added mapping for TextMap_MediumEN.json to match database split
CRITICAL FIX: Prevents complete data loss (0-byte files) during database updates by implementing proper download-validate-replace pattern instead of delete-before-download approach. Previous behavior (BROKEN): 1. if (force) File.Delete(file) - deletes existing data FIRST 2. LoadJsonFromFile() creates empty 0-byte file 3. Processing fails → status stays Skipped 4. File never saved → 0-byte file remains = DATA LOSS New behavior (FIXED): 1. Load existing data (or empty dict if force mode) 2. Work on copy (newData), keeping original as fallback 3. Process updates into newData 4. Validate newData before saving 5. Only replace file if validation passes 6. If validation fails → keep existing data, log error Changes: - UpdateCharacters: Implement download-validate-replace pattern with ValidateCharacterData() (≥50 chars, critical chars exist) - UpdateArtifacts: Add ValidateArtifactData() (≥30 sets) - UpdateWeapons: Add ValidateWeaponData() (≥100 weapons) - UpdateMaterials: Add ValidateMaterialData() (≥50 materials) - Remove all File.Delete() calls before download - Work on newData copy, preserve original as fallback - Add comprehensive validation before saving any data This prevents shipping with corrupt/empty data files and ensures updates are atomic - either fully succeed with validated data or keep existing data intact. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fix database update data loss from optimistic delete anti-pattern
Switches the base raw-data URL from AnimeGameData/master to AnimeGameData2/main to follow the current upstream dataset. Also fixes two critical weapon keys (`silversword`, `beginnersprotector`) so validation checks use the correct IDs and avoid false missing-weapon errors.
Updates `AssemblyVersion` in `AssemblyInfo.cs` from `1.4.3.*` to `1.4.4.*` for the next release increment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.