Make test suite resilient to missing networkx; fix OSMWay default#91
Merged
Conversation
networkx is an optional dependency, but two tests failed outright when it was not installed: - convert_graph_test: importing/calling convert_to_networkx raised NameError. The test class is now skipped via @skipUnless when networkx is unavailable. - integration_test: run.py was always invoked with --networkx, which exits non-zero without networkx. --networkx is now only passed when networkx is installed, so the core pipeline is still exercised. Also give OSMWay.max_speed_int a default of 0. It was declared with field(init=False) and no default, so accessing it on a way that was never accepted (max_speed_int never assigned) raised AttributeError. Test suite now passes cleanly with or without networkx installed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
networkx is an optional dependency, but two tests failed outright when it was not installed:
Also give OSMWay.max_speed_int a default of 0. It was declared with field(init=False) and no default, so accessing it on a way that was never accepted (max_speed_int never assigned) raised AttributeError.
Test suite now passes cleanly with or without networkx installed.