Feat/value list dict json support#315
Merged
Merged
Conversation
…erter Read and write keys through the JsonConverter<T> that the options resolve for the key type (ReadAsPropertyName/WriteAsPropertyName) instead of Convert.ToString/Convert.ChangeType. This adds support for Guid, enum, bool, floating-point and every other built-in dictionary key type, applies DictionaryKeyPolicy to all keys, and makes complex keys work on the same terms as a normal Dictionary<,> (via a custom key converter). Repeated property names now collapse to last-wins at the original position. Expand the tests to mirror the runtime's CustomConverterTests: a key/value type matrix (string, int, Guid, enum, bool, double, complex values), all eight concrete and interface variants, and read edge cases (null root, empty object, empty/null value lists, duplicate keys, non-object root). Add shared scenario tests that run identically against both converter registration and [JsonConverter] attribute usage.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.