Skip to content

ICMP and IPv4 support - #121

Draft
Amjad50 wants to merge 7 commits into
masterfrom
icmp_support
Draft

ICMP and IPv4 support#121
Amjad50 wants to merge 7 commits into
masterfrom
icmp_support

Conversation

@Amjad50

@Amjad50 Amjad50 commented Jan 5, 2025

Copy link
Copy Markdown
Owner

Summary

Create abstractions to handle ICMP, and IPV4 packets on the network stack

Related issue

Work toward #75

Changes

  • Add ARP packet handling
  • Add Ipv4Address struct
  • Add mac_address cmdline parameter that can be used to override the default mac address.

Checklist

  • The changes are tested and works as expected (mention if not)
  • Tests if applicable (new features, regression tests, etc...)
  • Documentation
  • Needed README changes

@Amjad50 Amjad50 self-assigned this Jan 5, 2025
Its a better location since its not only related to `devices::net`

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
…cmdline

Also updated `cmdline.md` docs

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
The next step into getting IPv4 working

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
@Amjad50
Amjad50 marked this pull request as draft January 5, 2025 14:02
Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
The building block for getting `ping` to work

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
The issue with the previous method is that you need to know/predict what
headers there will be, which is unrealistic, so this is a better option.

tbh, this is probably not a very nice nor efficient method, but still
planning what to change it to.

For now its okay I guess

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
Just `halt`

And also some `clippy` fixes

Signed-off-by: Amjad Alsharafi <26300843+Amjad50@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant