string: add __xpg_strerror_r for objects built against newlib headers - #14
Open
codewiz wants to merge 1 commit into
Open
string: add __xpg_strerror_r for objects built against newlib headers#14codewiz wants to merge 1 commit into
codewiz wants to merge 1 commit into
Conversation
The newlib string.h in sys-include renames strerror_r to __xpg_strerror_r unless _GNU_SOURCE is defined, so libstdc++ objects reference that symbol and every link pulling in <system_error> fails against libnix. Provide the POSIX variant next to the GNU-style strerror_r.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newlib string.h installed in sys-include renames strerror_r to
__xpg_strerror_runless_GNU_SOURCEis defined, so libstdc++'s system_error.o references that symbol and every link pulling in<system_error>or<string>fails against libnix.This is bucket 2 of the C++ testsuite umbrella issue AmigaPorts/m68k-amigaos-gcc#57 (~508 link failures, most of the unresolved tests) and the root cause of AmigaPorts/m68k-amigaos-gcc#27.
Provide the POSIX variant next to the existing GNU-style strerror_r: return 0 on success, ERANGE when the buffer is too small (copying what fits), EINVAL for an out-of-range errnum (writing "Unknown error"), which is exactly what libstdc++'s use_strerror_result handles.
Verified: a
<system_error>testcase that previously failed to link with -noixemul now links and prints "I/O error" under vamos.