Casimir/enhancement/652 implement new figma design for collapsed navbar#656
Casimir/enhancement/652 implement new figma design for collapsed navbar#656Casimir43 wants to merge 6 commits into
Conversation
…NavbarDesktopV3 to all pages
Casimir43
requested review from
Rutjake,
Skoivumaki,
leolabdev and
patinen
as code owners
Skoivumaki
left a comment
Skoivumaki
left a comment
There was a problem hiding this comment.
Good work 👍
Todo:
Remove the tests in V3, they are causing build to fail.
Remove toggleCollapse button:
@Rutjake Issue creator will decide if commented stuff is relevant to issue. Until then, ignore them.
| * @property {number} marginTop Margin at the top | ||
| * @property {string} className Additional CSS classes | ||
| * @property {NavbarBuild} navbarBuild Navigation bar components according to usage type and view size | ||
| * @property {boolean} isFixed This is deprecated. Fixed type is get from context |
There was a problem hiding this comment.
isFixed has been deprecated since V1. Fix it or remove it, or just update JSdoc if issue is not relevant anymore.
| // import NavbarDesktop from '../NavbarDesktop/NavbarDesktop'; | ||
| import NavbarDesktop from '../NavbarDesktopV3/NavbarDesktop'; | ||
| import NavbarMobile from '../NavbarMobileV3/NavbarMobile'; | ||
| // import NavbarMobile from '../NavbarMobile/NavbarMobile'; |
There was a problem hiding this comment.
Preferably don't leave old comments. We are building something new, so lets not keep unnecessary code.
There was a problem hiding this comment.
Why is V2 test included in V3?
There was a problem hiding this comment.
copied the whole component and forgot to remove them :(
Using the old component as a base was a good starting point, but it required updating, fixing, or removing some of the existing tests to match the new functionality. Please note that the component needs to be independent from V2. The toggleCollapse button is no longer present in this new version. This issue only covers updating the navbar bar in its closed state and replacing the logo. The rest of the NavBar updates will be handled in a separate issue. |
3 participants
📄 Pull Request Overview
Closes #652
🔧 Changes Made
✅ Checklist Before Submission
console.log()or other debugging statements are left. ✅📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Verified it renders correctly on each site.