Skip to content

testing a simple CI config first#850

Open
CapoMK25 wants to merge 3 commits into
devfrom
849-feature-request-jenkins-migrated-to-github-actions-or-something-similar
Open

testing a simple CI config first#850
CapoMK25 wants to merge 3 commits into
devfrom
849-feature-request-jenkins-migrated-to-github-actions-or-something-similar

Conversation

@CapoMK25
Copy link
Copy Markdown
Collaborator

Brief description

This is just a test for GitHub Actions in the future, might fail completely on the first run and might not even work together with Jenkins, since Jenkins is still active.

Change list

  • Added two workflows for the actions runners, thus the 2 added files. ci.yml and coverage.yml

@CapoMK25
Copy link
Copy Markdown
Collaborator Author

Too strict, has to rerun the classic Mongo test isolation bugs instead of failing the run completely. Adjusting.

@CapoMK25
Copy link
Copy Markdown
Collaborator Author

--runinband makes the CI loop forever on Actions, needs to be addressed in the coming days by me.

Copy link
Copy Markdown
Member

@hoan301298 hoan301298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current setup makes sense. Approved! Well done.

In the dedicated coverage.yml workflow, using if-no-files-found: error also makes sense since generating coverage is the primary goal there.

I added comments, some of them were from AI suggestions. Feel free to discuss and if you think they're no need for this ci workflows, ignore them 👍

Comment thread .github/workflows/ci.yml
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '24'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now we are using the lower version of node 20/22. It might be a problem in future. Just choose a safer one. Please check other usage as well. 😄

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently using Node v25.9.0

Comment thread .github/workflows/ci.yml
- name: Run tests (first attempt)
id: first_run
continue-on-error: true
run: npm run test -- --json --outputFile=test-results.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guarantee coverage exists

run: | 
    npm run test -- \ 
    --coverage \ 
    --json \ 
    --outputFile=test-results.json

push:
branches:
- dev

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents old coverage runs from continuing after new commits are pushed

concurrency:
  group: coverage-${{ github.ref }}
  cancel-in-progress: true

with:
name: coverage-report-${{ github.sha }}
path: coverage/
retention-days: 30 No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dedicated coverage workflow exists specifically to generate coverage.

If the coverage/ folder is missing there, something is wrong:

tests didn’t run correctly
coverage config broke
Jest stopped generating reports

So failing the workflow is useful:

if-no-files-found: error

because coverage generation is the primary goal of that workflow.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants