🔧 fix P2-3049 + P2-3053: empty Center cell + dynamic ToC reporting-phase year (staging bundle)#708
Merged
yecksin merged 6 commits intoJun 23, 2026
Conversation
…ly in ToC report views
The Reporting-by-ToC views hardcoded the literal "2025" so they kept showing
"Reporting Phase 2025" / "Expected target 2025" after the 2026 phase opened.
Bind these to the active reporting phase year instead.
- Add EntityAowService.reportingPhaseYear getter (active phase year, '' until
loaded so the UI never renders "null").
- entity-aow-aow + entity-aow-2030: phase header now "Reporting Phase {year}".
- aow-hlo-table: "Expected target {year}" column built via computed from the
active phase year (shared by High-Level Outputs, Intermediate Outcomes and
2030 Outcomes — one change covers all three).
- aow-hlo-create-modal: the 3 hardcoded "2025" mentions in the target
description now use the dynamic year.
- Update aow-hlo-table.component.spec.ts accordingly.
Scope: report-result views only. Previously-reported/historical data is left
untouched (indicator-details "achieved by end of 2024" / achieved_in_2024 field
and the 2022-2024 baseline). Frontend-only. Remaining nomenclature items from
the ticket are tracked in a Jira comment tagged to Santiago Sanchez + Angel.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CyLZHACEnyTLf3xAEsZUbS
…efined" When a result has no lead center (it is led by an external partner), the Center column rendered the literal text "Undefined". Replace the hardcoded fallback `|| 'Undefined'` with an empty string so the cell stays blank. Added a TODO (P2-3049) note documenting that a future change should fall back to displaying the lead partner when no lead center exists. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…l validation Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…menclature
Per Santiago Sánchez's clarification (2026-06-22) for the Reporting-by-ToC interface:
- Entry-point cards (entity-details): "Reporting by Theory of Change" → "Results
planned in your {year} ToC" with a question-circle tooltip ("Report results as
planned theory of change"); "Reporting by Result Category" → "Report Emerging
results" with a question-circle info note explaining results that emerged
outside the {year} Theory of Change. Year is the dynamic active phase.
- HLO / Outcomes / 2030 Outcomes table headers (aow-hlo-table): Indicator name →
"KPI statement", Type → "Indicator typology", "Expected target {year}" →
"{year} target" (dynamic), Actual achieved → "Achieved target".
- Add TooltipModule to entity-details; update aow-hlo-table spec assertions.
Frontend-only, report-views only. Historical/previously-reported data untouched.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CyLZHACEnyTLf3xAEsZUbS
…ctive' into P2-3049 (bundle for staging validation)
yecksin
changed the title
…arCloud code smell The "TODO" keyword triggered a SonarCloud maintainability code smell. The future scope (fall back to lead partner) is already tracked in Jira, so the in-code comment is reworded as a NOTE without changing its meaning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2-3049 — Results list: empty Center cell instead of "Undefined"
Summary
"Undefined"when a result had no lead center (led by an external partner).|| 'Undefined'with|| ''so the cell is left blank.TODO (P2-3049)comment noting that a future change should fall back to the lead partner when there is no lead center.Why this approach is correct
"Undefined"was never a real value — just a hardcoded fallback. A blank cell is the least-surprising behavior for a result with no lead center.lead_centercolumn (no duplicated path).Code walkthrough
P2-3053 — ToC report views: show active reporting-phase year dynamically
Summary
entity-aow.service) and surfaced acrossentity-details,entity-aow, andaow-hlo-table.Why this approach is correct
openspec/changes/p2-3053-dynamic-reporting-phase-year/.Verification
🤖 Generated with Claude Code