Initial ScoreSaber improvement dump#111
Draft
Umbranoxio wants to merge 16 commits into
Draft
Conversation
(instead of color)
Merge with dev
connection/loading logic is just a temporary hack since it's all going to be redone soon:tm:
… source abstraction (AllPoland#107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #110 -- diff will look larger than it is until that whole branch ends up in main
This is our first "shared" feature / improvement dump we're upstreaming from our fork so it's a smidge larger than what our future contributions would be. Future PRs will be a lot more bite sized and well.. normal
Anywho, changes:
I think this is everything we had on the ScoreSabers side that makes sense to upstream currently.