Fix/adversarial review remediation - #30
Merged
Merged
Conversation
…ommit lockfiles
- root .gitignore: stop ignoring package-lock.json; commit lockfiles for all
three frontends so dependency trees are reproducible.
- ai-dashboard/frontend (ops console):
* vite dev proxy: add /ops -> localhost:8080
* Settings/Images: use getErrorMessage(err) so API failures (non-Error
rejection payloads) actually surface an error message
* router ProtectedLayout: fetch user info before deciding; render a loading
placeholder meanwhile instead of flashing a /login redirect on hard refresh
- ai-dev-console/console/frontend-new:
* MainLayout: replace the 1.5s setTimeout auth check with a blocking check;
protected content is no longer rendered before the session is verified
- ai-dev-console/console/frontend (legacy umi 3 / webpack 4, see OPTIMIZATION.md):
* build scripts: NODE_OPTIONS=--openssl-legacy-provider (OpenSSL 3 md4)
* overrides: pin swr to 2.4.2 (^2.0.0 floats to 2.5.x which breaks wp4)
* config.js chainWebpack: parse .mjs as javascript/auto (wp4 CJS interop)
* prebuild lint no longer blocks the build (~490 pre-existing errors)
* engines.node >= 16
* rebuild dist/: removes eval('('+detail.jobConfig+')') XSS from the shipped
bundle; source already used JSON.parse but dist had never been rebuilt
Security: - dashboard: adminOnly on all management routes & Grafana proxy, OAuth state, DeleteUser nil guard, node-shell timeout/random suffix/dedup, IMS pagination, TokenRequest fallback for K8s>=1.24, RRSA role ARN fix, remove Password field - dev-console legacy: session-based notebook identity & ownership checks, token stripped from responses, server-generated notebook tokens, auth suffix-bypass and /common port hardening, pipeline/mlflow proxy identity, SLS injection and pagination fixes, tenant registry locking, arena client error propagation, kubeconfig path sanitization (0600), remove hardcoded JWT & token logs Correctness: - restore module compilation (clientmgr/signals), add missing backend entry points (both consoles), deepcopy drift, gorm zero-value writes + optimistic lock, idempotent mysql migrations, pod status/tenancy conversion, notebook stop/start & job stop route contracts, tensorboard endpoints, 7+ index-out panics, workloadgate detection, k8sutil nil guards, list limits Build/deploy: - switch both consoles to the new stack (internal backends + frontend-new), retire removed operator build path, fix chart dependency paths, add OIDC_ROLE_ARN & auto session secret to charts, add consoles CI workflow, update Makefile/Dockerfiles/BUILD.md/CLAUDE.md Verified: go build/vet/test green for ai-dashboard, ai-dev-console and notebook-controller; all three frontends build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.