Developed bio_tool#1
Open
AlinaPotyseva wants to merge 16 commits into
Open
Conversation
nvaulin
reviewed
Oct 16, 2023
nvaulin
left a comment
nvaulin
left a comment
There was a problem hiding this comment.
Привет!
Очень хорошая работа, спасибо
- Классный README, спасибо
- Хорошие названия коммитов.
- Вижу изменения по прошлым ДЗ, это радует, хотя что-то осталось не исправленным:)
- По фильтратору. Все работает верно и кажется на 99% так как это и было у меня в голове. Обрати только внимание на всякие мелкие моментики.
Баллы
- За модуль и качество кода 2.9/3
- За работу над ДЗ 3 и 4 0.7/1
- README 2/2
- За главную функцию фильтрации 1/1
- За 3 фильтратора 3/3
Итого: 9.6
| *** | ||
| > *Using this repository you can take advantage of several programs for working with nucleic acids, proteins and fastq sequences.* | ||
| *** | ||
| ## Table of contents |
Comment on lines
+31
to
+40
| ```python | ||
| -/ | ||
| |- bio_tools.py | ||
| |- README.md | ||
| |- modules/ | ||
| |- dna_rna_tool.py | ||
| |- доп_модуль_2.py | ||
| |- fastaq_tool.py | ||
| |- ... | ||
| ``` |
There was a problem hiding this comment.
Хех, ну это наверное не особо нужно в ридми:)
|
|
||
| To work with the program a user only needs to import the main script and call any of the three functions from it. | ||
|
|
||
| ### Installation |
Comment on lines
+1
to
+5
| TRANSCRIBE_DICT = dict(A='A', T='U', G='G', C='C', | ||
| a='a', t='u', g='g', c='c') | ||
| DNA_COMPLEMENT_DICT = dict(A='T', T='A', G='C', C='G', | ||
| a='t', t='a', g='c', c='g') | ||
| RNA_COMPLEMENT_DICT = dict(A='U', U='A', G='C', C='G', |
Comment on lines
+16
to
+19
| if (dna_rna_alphabet.issuperset(nucleic_acid)): | ||
| return True | ||
| else: | ||
| return False |
There was a problem hiding this comment.
Suggested change
| if (dna_rna_alphabet.issuperset(nucleic_acid)): | |
| return True | |
| else: | |
| return False | |
| return dna_rna_alphabet.issuperset(nucleic_acid): |
Не надо проверять результат булевой операции чтобы вернуть булево значение, можно сразу возвращать булевый результат
Comment on lines
+1
to
+3
| import modules.fastaq_tool as fqt | ||
| import modules.dna_rna_tool as drt | ||
| import modules.protein_tool as prt |
| import modules.fastaq_tool as fqt | ||
| import modules.dna_rna_tool as drt | ||
| import modules.protein_tool as prt | ||
| from typing import List, Optional, Tuple, Union |
There was a problem hiding this comment.
Еще есть такая история: в питоне принято сперва импортировать сторонние модули, а потом свои
| import modules.protein_tool as prt | ||
| from typing import List, Optional, Tuple, Union | ||
|
|
||
| def fastaq_tool_running(seqs: dict, gc_bounds: int or float or tuple = (0, 100), |
There was a problem hiding this comment.
Название не оч хорошее:)
и не глагол, и fastaq вместо fastq
А еще не уверен что с аннотацией типов так будет работать через or:)
| :return: returns a dictionary consisting of only those sequences that pass | ||
| all conditions | ||
| """ | ||
| result = {} |
There was a problem hiding this comment.
Suggested change
| result = {} | |
| results = {} |
| else: | ||
| pass | ||
| if len(results) == 1: | ||
| results_str = str(results[0]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here it is some useful tools for a junior bioinformatician