Resolving bug in `grb::dot` with nonblocking backend - #398

Merged

anyzelman merged 8 commits into

397_dot_value_nonblocking

Dec 23, 2025

Commits on Dec 18, 2025

Added test reproducing bug

GiovaGa
authored and
anyzelman
committed
fixup! Added test reproducing bug

GiovaGa
authored and
anyzelman
committed
Fixing bug (seemingly)

GiovaGa
authored and
anyzelman
committed
Further fixes

GiovaGa
authored and
anyzelman
committed
Partial revert "Further fixes"

GiovaGa
authored and
anyzelman
committed
The implementation looked off to me (the same indices should be read from the left and right inputs). I extended the unit tests to try trip up the new implementation, but I appear to have not been …
anyzelman
committed
Revert one of the previous fixes -- we should always iterate over the nonzeroes of x, since that is the vector with guaranteed the fewest number of nonzeroes. Instead, the error was in the computat…
anyzelman
committed

Commits on Dec 23, 2025

Raised issue 408, removed comments
anyzelman
committed