Skip to content

Fix deprecated string-comparison format for depends_on macos - #4

Open
narnd wants to merge 1 commit into
AlexStrNik:mainfrom
narnd:fix-depends-on-macos-deprecation
Open

Fix deprecated string-comparison format for depends_on macos#4
narnd wants to merge 1 commit into
AlexStrNik:mainfrom
narnd:fix-depends-on-macos-deprecation

Conversation

@narnd

@narnd narnd commented Jun 21, 2026

Copy link
Copy Markdown

What

Change depends_on macos: ">= :ventura" to depends_on macos: :ventura in Casks/browserino.rb.

Why

Recent Homebrew (6.x) deprecated the string-comparison format for depends_on macos:. Installing/upgrading the cask currently prints:

Calling "string comparison format for depends_on macos:" is deprecated!
Use `depends_on macos: :ventura` instead.

A bare version symbol already uses a >= comparator under the hood, so depends_on macos: :ventura means the same thing ("Ventura or newer") and is exactly what brew style --fix autocorrects to. Purely cosmetic — nothing was broken — but it silences the warning for everyone using the tap.

🤖 Generated with Claude Code

Homebrew deprecated the string-comparison format for `depends_on macos:`.
`depends_on macos: ">= :ventura"` now emits:

  Calling "string comparison format for depends_on macos:" is deprecated!
  Use `depends_on macos: :ventura` instead.

A bare symbol already means "this version or newer" (default >= comparator),
so this is semantically identical and matches `brew style`'s autocorrect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 21, 2026 18:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Homebrew Cask definition for Browserino to use the current depends_on macos: syntax, eliminating deprecation warnings on recent Homebrew versions while preserving the same minimum macOS requirement.

Changes:

  • Replaced deprecated string-comparison syntax (">= :ventura") with the version symbol form (:ventura) for depends_on macos:.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EchoCloud

EchoCloud commented Jun 29, 2026

Copy link
Copy Markdown

This appears to correct the error reported by current hombrew:

Warning: Calling string comparison format for `depends_on macos:` is deprecated! Use `depends_on macos: :ventura` instead.
Please report this issue to the alexstrnik/homebrew-browserino tap (not Homebrew/* repositories), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/alexstrnik/homebrew-browserino/Casks/browserino.rb:11

@EchoCloud EchoCloud left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrects:

Warning: Calling string comparison format for `depends_on macos:` is deprecated! Use `depends_on macos: :ventura` instead.
Please report this issue to the alexstrnik/homebrew-browserino tap (not Homebrew/* repositories), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/alexstrnik/homebrew-browserino/Casks/browserino.rb:11

@jlucktay

jlucktay commented Jul 2, 2026

Copy link
Copy Markdown

Duplicate of #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants