Fix Citadel surface rules overwriting modded surface rules + Improve mixin compatibility#224
Open
BluSpring wants to merge 4 commits intoAlexModGuy:1.21from
Open
Fix Citadel surface rules overwriting modded surface rules + Improve mixin compatibility#224BluSpring wants to merge 4 commits intoAlexModGuy:1.21from
BluSpring wants to merge 4 commits intoAlexModGuy:1.21from
Conversation
BluSpring
changed the title
digi2303
approved these changes
Apr 14, 2026
|
Hi, after running into this issue myself, I can confirm that one of the impacted mods is Biomes We've Gone, and one of the impacted biomes is Rainbow Beach, if that helps with testing. With Citadel installed, Rainbow Beach generates grass instead of the rainbow sand as expected. |
…1-issue223 # Conflicts: # src/main/java/com/github/alexthe666/citadel/mixin/MinecraftServerMixin.java
Author
|
Apparently my Git didn't properly sync with the upstream changes... Regardless, seems to work perfectly fine now. |
BluSpring
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Based on Raguto/Citadel-1.21.1#6. Needs further testing, I'm unsure which mods are affected by this issue.
Additional changes were made to try to improve Citadel's mixin compatibility with other mods.