Skip to content

Add silent parameter to some CommonActions Apply methods to suppress visual effects #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamali292 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

Add silent parameter to some CommonActions Apply methods to suppress visual effects #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Utils/CommonActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,26 +481,29 @@ public static async Task<IEnumerable<CardModel>> SelectCards(CardModel card, Loc
/// The card play instance carrying the selected target for single-target cards.
/// May be <see langword="null"/> for untargeted cards.
/// </param>
/// <param name="silent">
/// If <see langword="true"/>, suppresses visual effects when the power is applied.
/// </param>
/// <returns>
/// A list of all applied power instances, or an empty list if no valid targets were found.
/// </returns>
public static async Task<IReadOnlyList<T>> Apply<T>(PlayerChoiceContext ctx, CardModel card, CardPlay? cardPlay) where T : PowerModel
public static async Task<IReadOnlyList<T>> Apply<T>(PlayerChoiceContext ctx, CardModel card, CardPlay? cardPlay, bool silent = false) where T : PowerModel
{
if (cardPlay?.Target != null)
{
return await Apply<T>(ctx, cardPlay.Target, card) is { } result ? [result] : [];
return await Apply<T>(ctx, cardPlay.Target, card, silent) is { } result ? [result] : [];
}

return await ApplyToCreatures<T>(card, ctx, card.GetTargets());
return await ApplyToCreatures<T>(card, ctx, card.GetTargets(), silent);
}

private static async Task<IReadOnlyList<T>> ApplyToCreatures<T>(CardModel card, PlayerChoiceContext ctx, params Creature[] targets) where T : PowerModel
{
return await Apply<T>(ctx, targets, card);
}
private static async Task<IReadOnlyList<T>> ApplyToCreatures<T>(CardModel card, PlayerChoiceContext ctx, IEnumerable<Creature> targets) where T : PowerModel
private static async Task<IReadOnlyList<T>> ApplyToCreatures<T>(CardModel card, PlayerChoiceContext ctx, IEnumerable<Creature> targets, bool silent = false) where T : PowerModel
{
return await Apply<T>(ctx, targets, card);
return await Apply<T>(ctx, targets, card, silent);
}

/// <summary>
Expand Down