Bump the Gradle wrapper, checkout action and versions plugin - #47
Open
LaStrada wants to merge 1 commit into
Open
Bump the Gradle wrapper, checkout action and versions plugin#47LaStrada wants to merge 1 commit into
LaStrada wants to merge 1 commit into
Conversation
Gradle 8.14.4 -> 8.14.5, actions/checkout v6 -> v7, and the versions plugin 0.54.0 -> 0.59.0. Removing the buildscript classpath block is what makes the Gradle bump work. Those three entries interpolated `version.plugin.androidGradle`, `version.kotlin` and `version.plugin.outdated`, none of which exist in gradle.properties, so each resolved to the literal string "null". 8.14.4 tolerated it; 8.14.5 tries to resolve `gradle-versions-plugin:null` and fails. The block was already dead — the plugins block declares all three through the version catalog, as the comment above it says. Verified with `gradlew build` and `gradlew dependencyUpdates` on 8.14.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description ✏️
The safe subset of #37, so that PR can be closed:
actions/checkoutcom.github.ben-manes.versions8.14.5 matches airthings-app; android_ble_lib is on 8.13.
Left out deliberately: the Android Gradle Plugin. #37 wanted
8.10.0 → 9.3.1, but AGP 9 requiresGradle 9, and this build isn't ready for it — it still reports "Deprecated Gradle features were used in
this build, making it incompatible with Gradle 9.0".
dependencyUpdatesalso lists no stable AGPupgrade at all;
com.android.libraryshows up only under later milestone versions(
8.10.0 -> 9.4.0-alpha07). Gradle 9 and AGP 9 belong together in their own change, with their owntesting.
Why the buildscript block goes
Removing it is what makes the Gradle bump work, not unrelated tidying. Those three
classpathentriesinterpolated
version.plugin.androidGradle,version.kotlinandversion.plugin.outdated— none ofwhich exist in
gradle.properties, so each resolved to the literal string"null". Gradle 8.14.4tolerated that; 8.14.5 tries to resolve
com.github.ben-manes:gradle-versions-plugin:nulland fails.The block was already dead. The
plugins { }block declares all three through the version catalog, asthe comment directly above it says: "Versions of plugins are now configured once in pluginManagement
block in settings.gradle.kts."
Screenshots / Recordings 📷
How to Test 🐛
Both were run locally on 8.14.5 —
buildsucceeded with 146 tasks executed, anddependencyUpdatesproduced a report and identified itself as
0.59.0.References 🔗
Replaces the bumps in #37, which can be closed once this lands — its lint job is red on exactly the
Gradle 9 + AGP 9 combination left out here.
Still outstanding from #37's neighbourhood, as separate changes:
concurrencyonbuild.ymlso pushesdon't stack concurrent macOS runs, and
.github/actions/javamoving off the deprecatedadoptdistribution to
temurin.