ENG-2717: Send androidAppVersion in Android webview URL#157
Merged
Conversation
marc-n-dream
force-pushed
the
marc/ENG-2717
branch
2 times, most recently
from
3126560 to
83b9fab
Compare
Add the Android app version (Application.version) as an androidAppVersion query parameter on the webview URL to report the app version to the platform, matching the parameter already sent by the Automotive AirConsole Player. Extract the URL query assembly into a pure, device-independent BuildWebviewUrl seam so the Android and Web paths are unit-testable, and add PlayMode tests covering both. Pin the project to Unity 2022.3.62f3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
marc-n-dream
force-pushed
the
marc/ENG-2717
branch
from
83b9fab to
13b1c83
Compare
dragan-n-dream
approved these changes
Jul 2, 2026
dragan-n-dream
left a comment
dragan-n-dream
left a comment
Contributor
There was a problem hiding this comment.
Besides one comment LGTM.
The QueryString_IsWellFormed test assumed the connection URL starts with '?', but AirConsole builds it as a path with an embedded query start (client?id=...&runtimePlatform=android). Mirror that real format and assert the built URL starts with base+connection unchanged and keeps a single '?'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
androidAppVersion={Application.version}to the Android webview URL, alongside the existingbundle-version(Android-runtime only).CreateAndroidWebviewinto a pure, device-independentBuildWebviewUrlseam so the Android and Web paths can be tested without a device.AndroidWebviewUrlTests) covering both paths: Android-only params present on Android, absent on Web, shared params on both, well-formed query string, and correct field mapping.2022.3.62f3.Why
Report the Android application version to the platform for version tracking, matching the parameter already sent by the Automotive AirConsole Player.
Scope
androidAppVersionparameter, a behavior-preserving testability refactor, PlayMode tests, Unity version pin.Testing
-buildTarget Android—CheckPlatform([InitializeOnLoadMethod]) switches the build target on load, which segfaults in batchmode when starting from a non-Android/WebGL target.