Fix read_status failure for multiple statuses after actions#2
Open
huangruoqi wants to merge 2 commits into
Open
Fix read_status failure for multiple statuses after actions#2huangruoqi wants to merge 2 commits into
huangruoqi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
read_status()could fail due to multiple status data when usingreader.read(). The updated implementation usesreader.readexactly()to ensure the AES-encrypted payload is fully and correctly received before decryption.Problem
Previously,
read_status()used:Using this test script
causes:
This was unsafe because AES requires a block-aligned input; partial data causes decryption errors. This led to errors like:
Changes
Replaced read() with readexactly(8) for the header and readexactly(bodysize) for the encrypted payload in read_status().
Testing
Reran the test script:
{'online': True, 'on': 1, 'dimming': 249, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 249, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 0, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 0, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 48, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 48, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 99, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 99, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 147, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 147, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 198, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 198, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)} {'online': True, 'on': 1, 'dimming': 249, 'rgdb': -4422400, 'rgbw': (255, 188, 133, 0)}