Fix for missing DeviceClient.writer#1
Open
toxuin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash for a case when the integrating app is trying to open comms with a device that has not been connected to yet. Ideally, it should fail gracefully, but it currently crashes the whole app with an error
AttributeError: 'DeviceClient' object has no attribute 'writer'.The first assignment to those attributes happens in
connect, so in a happy path scenario it works alright, but happens to explode if any method was called beforeconnect. This should fix that.This PR fixes that by initializing both reader and writer to None values in the constructor - just like in
connectmethod.