Use compact offsets+indices neighbor-list representation and compressed index type#199
Open
AhmedSalih3d wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Vector{Int}neighbor lists with a contiguous offsets+indices representation to reduce allocations and improve cache locality and iteration speed.CellIndexMapfor fast cell lookup in boundary/MDBC routines.Description
NeighborCellIndexType = UInt32and helperCompressIndexfor safe index compression and export the new type viaSPHNeighborListimports.BuildNeighborCellLists!(NeighborCellListOffsets, NeighborCellListIndices, FullStencil, UniqueCellsView, ParticleRanges, CellIndexMap)and an overload that fills aCellIndexMapfor the legacy API, while retaining the originalBuildNeighborCellLists!behavior where needed.NeighborCellListsusages withNeighborCellListOffsets/NeighborCellListIndicesand update neighbor iteration sites inSPHCellList(NeighborLoopPerParticle!,SimulationLoop, MDBC flow) to iterate by cursor over offsets and toInt-cast compressed indices when needed.GhostCellIndexfunction andCellIndexMapgetlookups instead ofFindCellIndex, and updateApplyMDBCBeforeHalf!to pass the new arguments; updateComputeCellNeighborCountsto support the new offsets+indices layout.FinalizeSimulationOutput!to createNeighborCellListOffsets,NeighborCellListIndices, andNeighborCellIndexMapand wire them through the simulation loop and neighbor-list rebuilds.Testing
Codex Task