Keep support arrays aligned on neighbor rebuild#193
Open
AhmedSalih3d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SimParticlesin place which can desynchronize separate per-particle work arrays (e.g.Positionₙ⁺,Velocityₙ⁺,ρₙ⁺,dρdtI,∇Cᵢ,∇◌rᵢ) and corrupt the integrator whenShouldRebuildis triggered frequently.Description
UpdateNeighborsAligned!which computes the cell-sort permutation, applies it toParticles, and then applies the same permutation to any provided aligned per-particle arrays before rebuilding cell ranges (new functions insrc/SPHNeighborList.jl).RebuildCellRanges!and updatedUpdateNeighbors!to reuse that helper so the legacy path is preserved.UpdateNeighborsAligned!, passingdρdtI,Velocityₙ⁺,Positionₙ⁺,ρₙ⁺,∇Cᵢ, and∇◌rᵢso these support arrays stay aligned withSimParticles(src/SPHCellList.jl).aligned neighbor rebuildtotest/runtests.jl; tests were also updated to use currentΔtandFullTimeStepargument forms.Testing
julia --project=. -e 'using Pkg; Pkg.test()', and the full test suite passed.UpdateNeighborsAligned!and succeeded under test.Codex Task