Decouple output scheduling from solver state#191
Open
AhmedSalih3d wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OutputTimes, changing physics outcomes.Description
SimulationRuntimeStateholdingΔx,dt, and an initialization flag, and threaded it intoSimulationLoopto avoid resetting these when the loop is re-entered (src/SPHCellList.jl).SimulationLoopsignature to acceptRuntime::SimulationRuntimeState{FloatType}and updated the loop to read/writeRuntime.ΔxandRuntime.dt, and to perform the initial neighbor-list build only once.Runtimeinstance inRunSimulationand passed it intoSimulationLoopso neighbor-list rebuild timing and adaptivedtpersist across outputs (src/SPHCellList.jl).next_output_time(times::AbstractVector, ...)indexing to use<= length(times)so the final configured output time is reachable (src/TimeStepping.jl).Δtmethod that accepts(Position, Velocity, Acceleration, SimulationConstants, SPHKernel)and computes the max acceleration from the acceleration vector for compatibility with existing tests (src/TimeStepping.jl).Testing
julia --project=. -e 'using SPHExample'which precompiled and loaded the package successfully.julia --project=. -e 'using Pkg; Pkg.test()'; thetime steppingtests passed, but theisolated particletest errored due to aFullTimeStepsignature mismatch in the test harness (existing test callsFullTimeStepwith the older 7-argument signature), so the full test suite did not complete successfully.src/SPHCellList.jlandsrc/TimeStepping.jland preserve the intended behaviour of keepingOutputTimespassive with respect to solver state.Codex Task