Ensure VTKHDF outputs are closed on simulation failures#189
Open
AhmedSalih3d wants to merge 1 commit into
Open
Ensure VTKHDF outputs are closed on simulation failures#189AhmedSalih3d wants to merge 1 commit into
AhmedSalih3d wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
FinalizeOnce!helper inRunWithSimulationFinalizer!to ensure output finalization runs exactly once across normal exit, Ctrl+C, Julia exit, and ordinary exceptions (src/SPHCellList.jl).atexithandler and interrupt path withFinalizeOnce!and add handling for non-interrupt exceptions that finalizes withlog_status="failed"before rethrowing.RunWithSimulationFinalizer!with a synthetic error and assertsclose_fileswas called (test/runtests.jl).Testing
julia --project=. -e 'using SPHExample'which precompiled and loaded the package successfully.RunWithSimulationFinalizer!with a forcederror("boom")and verified the providedclose_fileswas invoked (test passed).julia --project=. -e 'using Pkg; Pkg.test()'which exercised the new regression test but the overall test run failed due to a pre-existing unrelated failure in thetime steppingtest (Δtmethod signature mismatch).Codex Task