Preserve adaptive timestep across output blocks#185
Open
AhmedSalih3d wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OutputTimesboundary, making the I/O cadence influence the numerical solution instead of only the logging/export behavior.Description
dtfromSimMetaData.CurrentTimeStepwhen enteringSimulationLoopinstead of always using the CFL baseline.dt₂inside the inner time-stepping loop so it follows any adaptivedtchanges within the block.SimMetaData.CurrentTimeStepafter each solver iteration so the next output block resumes with the same timestep.Testing
julia --project=. -e 'using SPHExample'which precompiled and loaded the package successfully.git diff --checkand there were no whitespace/format issues.julia --project=. -e 'using Pkg; Pkg.test()'which exercised the test suite and produced an error in the existing time-stepping test: the test callsΔt(pos, vel, acc, sc, ker)but onlyΔt(max_acceleration, SimulationConstants, SPHKernel)is defined, so the failure is in the test API usage rather than this change.Codex Task