Support Float32 simulation paths#184
Open
AhmedSalih3d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Float32without accidental promotion toFloat64or reinterpret casts that fail for smaller floats.SVectors to 3D so generated vectors keep the same float precision.Float32.Description
Float64-only reinterpret trick inEstimate7thRootwith a type-generic implementation and add an overload forReal, and updateInverseHydrostaticEquationOfStateto be type-preserving. (src/SimulationEquations.jl)to_3dby constructingSVector{3,eltype(v)}and usingzero(eltype(v))for the z-component. (src/AuxiliaryFunctions.jl)zero(q)so scalarqinputs (includingFloat32) produce a zero of the correct type. (src/SPHKernels.jl)Δtoverload that accepts particlePosition,Velocity, andAccelerationvectors and computes the maximum acceleration before delegating to the scalarΔtpath. (src/TimeStepping.jl)Float32coverage testset exercising constants, kernel instance creation,Estimate7thRoot,InverseHydrostaticEquationOfState,tensile_correction,to_3d, and the particle-vectorΔt. (test/runtests.jl)Testing
julia --project=. test/runtests.jland observed the full test suite (including the newFloat32 supporttests) pass. (success)julia --project=. -e 'using SPHExample, StaticArrays; T=Float32; ...'that asserts key functions and types returnFloat32values and thatΔtreturns aFloat32timestep. (success)julia --project=. -e 'using Pkg; Pkg.test()'but the invocation stalled during temporary test-environment precompilation; the direct test file execution was used to validate changes instead. (precompilation stalled)Codex Task