Branch shifting limiter terms#181
Open
AhmedSalih3d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MotionLimiterConditionboolean scalar multiplication with an explicitif ParticleType[i] == Fluid && ParticleType[j] == Fluidbranch in the kernel-output shifting path insrc/SPHCellList.jlsoVᵢand shift accumulations are only computed for fluid-fluid pairs.src/SPHCellList.jlto avoid computing unnecessaryshift_c_accandshift_r_accterms for non-fluid pairs.src/SPHCellList.jl.Testing
julia --project=. -e 'using Pkg; Pkg.test()', which errored in an existingtime steppingtest due to a preexistingMethodError: no method matching Δt(...)unrelated to this change (tests did not pass).julia --project=. -e 'using SPHExample; println("loaded")'which succeeded and precompiled the package.boolmul seconds=0.016947455,branched seconds=0.006823296, and identical numeric results (same=true).git diff --check(no whitespace/errors reported) as part of verification.Codex Task