Encode time-stepping mode in SimulationMetaData and dispatch neighbor loops#177
Open
AhmedSalih3d wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SimTimeSteppingargument fromRunSimulationto simplify caller code and example scripts.Description
TimeSteppingModeabstract type and concrete typesSymplecticTimeSteppingandSingleNeighborTimeStepping, and extendSimulationMetaDatawith aTModetype parameter.SimulationMetaDataconstructor that defaultsTModetoSingleNeighborTimeSteppingto preserve prior behavior.SimTimeSteppingparameter and theTimeSteppingModefield from runtime metadata, and updateRunSimulationsignature to accept theSimulationMetaDatawith the time-stepping mode encoded in its type.InitialNeighborLoop!andHalfStepNeighborLoops!methods specialized forSymplecticTimeSteppingandSingleNeighborTimeStepping, and refactorSimulationLoopto call these helpers instead of branching inline; update README and example scripts to reflect the new metadata-driven configuration.Testing
Codex Task