Specialize particle boundary types#176
Open
AhmedSalih3d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StructArrayshape concrete so the particle field tuple is visible to methods called fromRunSimulationand neighbor loops.Description
SimParticleStructArrayalias insrc/PreProcess.jlasconst SimParticleStructArray{ParticleTuple, FieldArrays, IndexType} = StructArray{ParticleTuple, 1, FieldArrays, IndexType}and export it.SimParticleStructArray{ParticleTuple, FieldArrays, IndexType}type into signatures forRunSimulation,SimulationLoop, allNeighborLoopPerParticle!overloads, andComputeInteractionsPerParticle!variants insrc/SPHCellList.jlso the particle tuple and field arrays are concrete to the compiler.SetupVTKOutputinsrc/ProduceHDFVTK.jlto accept a typedStructArray(StructArray{ParticleTuple, 1, FieldArrays, IndexType}) and add the necessaryStructArraysimport.SimParticleStructArrayfrom the package entrypoint insrc/SPHExample.jlso downstream code can use the alias in signatures.Testing
julia --project=. -e 'using SPHExample; println("loaded")', which succeeded.julia --project=. -e 'using Pkg; Pkg.test()', which errored:time steppingtest raisedMethodErrorfor aΔtcall (no matching 5-argument method); this failure appears unrelated to the particle-container specialization.Codex Task