Make time-stepping mode a SimulationMetaData type parameter#175
Open
AhmedSalih3d wants to merge 4 commits into
Open
Make time-stepping mode a SimulationMetaData type parameter#175AhmedSalih3d wants to merge 4 commits into
AhmedSalih3d wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TimeSteppingModeas an abstract field so compiled inner loops can reason about the time-stepping strategy at compile time.SimulationMetaDataconstructors while ensuring the concrete mode is available to performance-sensitive code paths.Description
TMode<:TimeSteppingModetype parameter toSimulationMetaDataand replace the runtimeTimeSteppingModefield with a concreteTimeSteppingMode::Type{TMode}stored value insrc/SimulationMetaDataConfiguration.jl._time_stepping_type,_metadata_kwargs_without_time_stepping_mode) and aSimulationMetaData{...}(; kwargs...)constructor that acceptsTimeSteppingModeas either a type or instance and yields aSimulationMetaDataspecialized on the chosenTMode.src/SPHCellList.jlto deriveTimeSteppingType = typeof(SimTimeStepping)inRunSimulation, pass thatTypeintoSimulationLoop, and branch on the compile-timeTMode(if TMode <: SingleNeighborTimeStepping/if TMode <: SymplecticTimeStepping) instead of reading an abstract field.SingleNeighborTimeSteppingwhen not specified.Testing
julia --project=. -e 'using SPHExample; meta=SimulationMetaData{2,Float64}(SimulationName="x", SaveLocation=".", TimeSteppingMode=SymplecticTimeStepping()); @show typeof(meta); @show meta.TimeSteppingMode; meta2=SimulationMetaData{2,Float64}(SimulationName="x", SaveLocation=".", TimeSteppingMode=SingleNeighborTimeStepping); @show typeof(meta2);'which succeeded and showed the metadata specialized on the selected time-stepping types.julia --project=. -e 'using Pkg; Pkg.test()'which precompiled successfully but thetime steppingtest errored due to an existingΔtmethod-signature mismatch (test callsΔtwith five arguments while only a three-argument method exists), so the test run did not fully pass.Codex Task