fix(geoip): create GEOIP_DB_DIR before writing — first refresh on a fresh container ENOENTed - #150
Merged
Conversation
…resh container ENOENTed 🤖 Built with SMT <smt@agora.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production bug from #149:
refreshGeoipDatabaseswrote its temp download file intoGEOIP_DB_DIRwithout creating the directory. A fresh container (Coolify's ephemeral filesystem) has no/app/geoip, so the very first startup refresh failed — observed live on prod asENOENT: ... open '/app/geoip/.tmp-City-*.mmdb', leaving all agentslow_confidence/Unverified. Dev never caught it because./geoipalready existed locally.Fix
fs.mkdir(dir, { recursive: true })as the first step of the refresh flow, injected throughRefreshDepslike the other fs operations so it stays testable. No call-site changes (defaults wired through the spread).Verification
rm -rf ./geoip→ dev-server start → startup auto-refresh created the dir and downloaded live DB-IP databases end-to-end.npm run check+ eslint clean.After merge, the Coolify auto-deploy makes prod self-heal on next start (no manual
mkdirneeded again).Generated with SMT smt@agora.build